From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 312B2C04AB6 for ; Fri, 31 May 2019 12:21:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1496E268B1 for ; Fri, 31 May 2019 12:21:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727358AbfEaMVu (ORCPT ); Fri, 31 May 2019 08:21:50 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:45585 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726330AbfEaMVu (ORCPT ); Fri, 31 May 2019 08:21:50 -0400 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1hWgXa-00084d-Q2; Fri, 31 May 2019 14:21:46 +0200 Message-ID: <1559305305.2557.3.camel@pengutronix.de> Subject: Re: [PATCH 2/2] ethtool: Add 100BaseT1 and 1000BaseT1 link modes From: Lucas Stach To: Andrew Lunn , Michal Kubecek Cc: netdev@vger.kernel.org, linville@redhat.com Date: Fri, 31 May 2019 14:21:45 +0200 In-Reply-To: <20190531115928.GA18608@lunn.ch> References: <20190530180616.1418-1-andrew@lunn.ch> <20190530180616.1418-3-andrew@lunn.ch> <20190531093029.GD15954@unicorn.suse.cz> <20190531115928.GA18608@lunn.ch> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am Freitag, den 31.05.2019, 13:59 +0200 schrieb Andrew Lunn: > > > @@ -634,10 +636,14 @@ static void dump_link_caps(const char *prefix, const char *an_prefix, > > > > > >     "100baseT/Half" }, > > > > > >   { 1, ETHTOOL_LINK_MODE_100baseT_Full_BIT, > > > > > >     "100baseT/Full" }, > > > > > > + { 1, ETHTOOL_LINK_MODE_100baseT1_Full_BIT, > > > > > > +   "100baseT1/Full" }, > > > > > >   { 0, ETHTOOL_LINK_MODE_1000baseT_Half_BIT, > > > > > >     "1000baseT/Half" }, > > > > > >   { 1, ETHTOOL_LINK_MODE_1000baseT_Full_BIT, > > > > > >     "1000baseT/Full" }, > > > > > > + { 1, ETHTOOL_LINK_MODE_1000baseT1_Full_BIT, > > > > > > +   "1000baseT1/Full" }, > > > > > >   { 0, ETHTOOL_LINK_MODE_1000baseKX_Full_BIT, > > > > > >     "1000baseKX/Full" }, > > >   { 0, ETHTOOL_LINK_MODE_2500baseX_Full_BIT, > > > > Does it mean that we could end up with lines like > > > >                                 100baseT/Half 100baseT/Full 100baseT1/Full > >                                 1000baseT/Full 1000baseT1/Full > > > > if there is a NIC supporting both T and T1? > > Hi Michal > > In theory, it is possible for a PHY to support both plain T and > T1. That's not just theory. The Broadcom BCM54811 PHY supports both 100/1000baseT, as well as 100baseT1. Regards, Lucas