From: Tom Herbert <tom@herbertland.com>
To: davem@davemloft.net, netdev@vger.kernel.org, dlebrun@google.com,
ahabdels.dev@gmail.com
Cc: Tom Herbert <tom@quantonium.net>
Subject: [RFC PATCH 1/6] seg6: Fix TLV definitions
Date: Fri, 31 May 2019 09:48:35 -0700 [thread overview]
Message-ID: <1559321320-9444-2-git-send-email-tom@quantonium.net> (raw)
In-Reply-To: <1559321320-9444-1-git-send-email-tom@quantonium.net>
The definitions of TLVs in uapi/linux/seg6.h are incorrect and
incomplete. Fix this.
TLV constants are defined for PAD1, PADN, and HMAC (the three defined in
draft-ietf-6man-segment-routing-header-19). The other TLV are unused and
and are marked as obsoleted.
Signed-off-by: Tom Herbert <tom@quantonium.net>
---
include/uapi/linux/seg6.h | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/include/uapi/linux/seg6.h b/include/uapi/linux/seg6.h
index 286e8d6..9117113 100644
--- a/include/uapi/linux/seg6.h
+++ b/include/uapi/linux/seg6.h
@@ -38,10 +38,13 @@ struct ipv6_sr_hdr {
#define SR6_FLAG1_ALERT (1 << 4)
#define SR6_FLAG1_HMAC (1 << 3)
-#define SR6_TLV_INGRESS 1
-#define SR6_TLV_EGRESS 2
-#define SR6_TLV_OPAQUE 3
-#define SR6_TLV_PADDING 4
+
+#define SR6_TLV_INGRESS 1 /* obsoleted */
+#define SR6_TLV_EGRESS 2 /* obsoleted */
+#define SR6_TLV_OPAQUE 3 /* obsoleted */
+
+#define SR6_TLV_PAD1 0
+#define SR6_TLV_PADDING 1
#define SR6_TLV_HMAC 5
#define sr_has_hmac(srh) ((srh)->flags & SR6_FLAG1_HMAC)
--
2.7.4
next prev parent reply other threads:[~2019-05-31 16:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 16:48 [RFC PATCH 0/6] seg6: Segment routing fixes Tom Herbert
2019-05-31 16:48 ` Tom Herbert [this message]
2019-05-31 16:48 ` [RFC PATCH 2/6] seg6: Implement a TLV parsing loop Tom Herbert
2019-05-31 16:48 ` [RFC PATCH 3/6] seg6: Obsolete unused SRH flags Tom Herbert
2019-05-31 16:48 ` [RFC PATCH 4/6] ah6: Create function __zero_out_mutable_opts Tom Herbert
2019-05-31 16:48 ` [RFC PATCH 5/6] ah6: Be explicit about which routing types are processed Tom Herbert
2019-05-31 16:48 ` [RFC PATCH 6/6] seg6: Add support to rearrange SRH for AH ICV calculation Tom Herbert
2019-05-31 17:07 ` Ahmed Abdelsalam
2019-05-31 17:34 ` Tom Herbert
2019-06-02 9:54 ` Ahmed Abdelsalam
2019-06-02 15:48 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559321320-9444-2-git-send-email-tom@quantonium.net \
--to=tom@herbertland.com \
--cc=ahabdels.dev@gmail.com \
--cc=davem@davemloft.net \
--cc=dlebrun@google.com \
--cc=netdev@vger.kernel.org \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).