From: Vedang Patel <vedang.patel@intel.com>
To: netdev@vger.kernel.org
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
stephen@networkplumber.org, vinicius.gomes@intel.com,
leandro.maciel.dorileo@intel.com, jakub.kicinski@netronome.com,
m-karicheri2@ti.com, Vedang Patel <vedang.patel@intel.com>
Subject: [PATCH iproute2 net-next v1 2/6] etf: Add skip_sock_check
Date: Thu, 6 Jun 2019 10:52:17 -0700 [thread overview]
Message-ID: <1559843541-12695-2-git-send-email-vedang.patel@intel.com> (raw)
In-Reply-To: <1559843541-12695-1-git-send-email-vedang.patel@intel.com>
ETF Qdisc currently checks for a socket with SO_TXTIME socket option. If either
is not present, the packet is dropped. In the future commits, we want other
Qdiscs to add packet with launchtime to the ETF Qdisc. Also, there are some
packets (e.g. ICMP packets) which may not have a socket associated with them.
So, add an option to skip this check.
Signed-off-by: Vedang Patel <vedang.patel@intel.com>
---
tc/q_etf.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tc/q_etf.c b/tc/q_etf.c
index 76aca476..85003dc1 100644
--- a/tc/q_etf.c
+++ b/tc/q_etf.c
@@ -130,6 +130,13 @@ static int etf_parse_opt(struct qdisc_util *qu, int argc,
explain_clockid(*argv);
return -1;
}
+ } else if (strcmp(*argv, "skip_sock_check") == 0) {
+ if (opt.flags & TC_ETF_SKIP_SKB_CHECK) {
+ fprintf(stderr, "etf: duplicate \"skip_sock_check\" specification\n");
+ return -1;
+ }
+
+ opt.flags |= TC_ETF_SKIP_SKB_CHECK;
} else if (strcmp(*argv, "help") == 0) {
explain();
return -1;
@@ -171,8 +178,10 @@ static int etf_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
print_uint(PRINT_ANY, "delta", "delta %d ", qopt->delta);
print_string(PRINT_ANY, "offload", "offload %s ",
(qopt->flags & TC_ETF_OFFLOAD_ON) ? "on" : "off");
- print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s",
+ print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s ",
(qopt->flags & TC_ETF_DEADLINE_MODE_ON) ? "on" : "off");
+ print_string(PRINT_ANY, "skip_sock_check", "skip_sock_check %s",
+ (qopt->flags & TC_ETF_SKIP_SKB_CHECK) ? "on" : "off");
return 0;
}
--
2.17.0
next prev parent reply other threads:[~2019-06-06 17:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 17:52 [PATCH iproute2 net-next v1 1/6] Kernel header update for hardware offloading changes Vedang Patel
2019-06-06 17:52 ` Vedang Patel [this message]
2019-06-06 17:52 ` [PATCH iproute2 net-next v1 3/6] taprio: Add support for enabling offload mode Vedang Patel
2019-06-06 19:43 ` Stephen Hemminger
2019-06-06 21:13 ` Patel, Vedang
2019-06-06 21:46 ` Stephen Hemminger
2019-06-06 22:22 ` Patel, Vedang
2019-06-06 17:52 ` [PATCH iproute2 net-next v1 4/6] taprio: add support for setting txtime_delay Vedang Patel
2019-06-06 19:44 ` Stephen Hemminger
2019-06-06 21:11 ` Patel, Vedang
2019-06-06 17:52 ` [PATCH iproute2 net-next v1 5/6] tc: etf: Add documentation for skip-skb-check Vedang Patel
2019-06-06 17:52 ` [PATCH iproute2 net-next v1 6/6] tc: taprio: Update documentation Vedang Patel
2019-06-06 21:15 ` [PATCH iproute2 net-next v1 1/6] Kernel header update for hardware offloading changes Patel, Vedang
-- strict thread matches above, loose matches on Subject: below --
2019-05-28 17:52 Vedang Patel
2019-05-28 17:52 ` [PATCH iproute2 net-next v1 2/6] etf: Add skip_sock_check Vedang Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559843541-12695-2-git-send-email-vedang.patel@intel.com \
--to=vedang.patel@intel.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=leandro.maciel.dorileo@intel.com \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).