netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Hancock <hancock@sedsystems.ca>
To: netdev@vger.kernel.org
Cc: anirudh@xilinx.com, John.Linn@xilinx.com, andrew@lunn.ch,
	davem@davemloft.net, Robert Hancock <hancock@sedsystems.ca>
Subject: [PATCH net-next v5 15/20] net: axienet: stop interface during shutdown
Date: Thu,  6 Jun 2019 16:28:19 -0600	[thread overview]
Message-ID: <1559860104-927-16-git-send-email-hancock@sedsystems.ca> (raw)
In-Reply-To: <1559860104-927-1-git-send-email-hancock@sedsystems.ca>

On some platforms, such as iMX6 with PCIe devices, crashes or hangs can
occur if the axienet device continues to perform DMA transfers after
parent devices/busses have been shut down. Shut down the axienet
interface during its shutdown callback in order to avoid this.

Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 6e75c43..d138db8 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1797,9 +1797,23 @@ static int axienet_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static void axienet_shutdown(struct platform_device *pdev)
+{
+	struct net_device *ndev = platform_get_drvdata(pdev);
+
+	rtnl_lock();
+	netif_device_detach(ndev);
+
+	if (netif_running(ndev))
+		dev_close(ndev);
+
+	rtnl_unlock();
+}
+
 static struct platform_driver axienet_driver = {
 	.probe = axienet_probe,
 	.remove = axienet_remove,
+	.shutdown = axienet_shutdown,
 	.driver = {
 		 .name = "xilinx_axienet",
 		 .of_match_table = axienet_of_match,
-- 
1.8.3.1


  parent reply	other threads:[~2019-06-06 22:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06 22:28 [PATCH net-next v5 00/20] Xilinx axienet driver updates (v5) Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 01/20] net: axienet: Fix casting of pointers to u32 Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 02/20] net: axienet: Use standard IO accessors Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 03/20] net: axienet: fix MDIO bus naming Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 04/20] net: axienet: add X86 and ARM as supported platforms Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 05/20] net: axienet: Use clock framework to get device clock rate Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 06/20] net: axienet: fix teardown order of MDIO bus Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 07/20] net: axienet: Re-initialize MDIO registers properly after reset Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 08/20] net: axienet: Cleanup DMA device reset and halt process Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 09/20] net: axienet: Make RX/TX ring sizes configurable Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 10/20] net: axienet: Add DMA registers to ethtool register dump Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 11/20] net: axienet: Support shared interrupts Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 12/20] net: axienet: Add optional support for Ethernet core interrupt Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 13/20] net: axienet: Fix race condition causing TX hang Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 14/20] net: axienet: Make missing MAC address non-fatal Robert Hancock
2019-06-06 22:28 ` Robert Hancock [this message]
2019-06-06 22:28 ` [PATCH net-next v5 16/20] net: axienet: document device tree mdio child node Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 17/20] net: axienet: Fix MDIO bus parent node detection Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 18/20] net: axienet: document axistream-connected attribute Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 19/20] net: axienet: make use of axistream-connected attribute optional Robert Hancock
2019-06-06 22:28 ` [PATCH net-next v5 20/20] net: axienet: convert to phylink API Robert Hancock
2019-06-06 23:24 ` [PATCH net-next v5 00/20] Xilinx axienet driver updates (v5) David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1559860104-927-16-git-send-email-hancock@sedsystems.ca \
    --to=hancock@sedsystems.ca \
    --cc=John.Linn@xilinx.com \
    --cc=andrew@lunn.ch \
    --cc=anirudh@xilinx.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).