From: Young Xiao <92siuyang@gmail.com>
To: steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Young Xiao <92siuyang@gmail.com>
Subject: [PATCH] af_key: Fix memory leak in key_notify_policy.
Date: Fri, 14 Jun 2019 16:26:26 +0800 [thread overview]
Message-ID: <1560500786-572-1-git-send-email-92siuyang@gmail.com> (raw)
We leak the allocated out_skb in case pfkey_xfrm_policy2msg() fails.
Fix this by freeing it on error.
Signed-off-by: Young Xiao <92siuyang@gmail.com>
---
net/key/af_key.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/key/af_key.c b/net/key/af_key.c
index 4af1e1d..ec414f6 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -2443,6 +2443,7 @@ static int key_pol_get_resp(struct sock *sk, struct xfrm_policy *xp, const struc
}
err = pfkey_xfrm_policy2msg(out_skb, xp, dir);
if (err < 0)
+ kfree_skb(out_skb);
goto out;
out_hdr = (struct sadb_msg *) out_skb->data;
@@ -2695,6 +2696,7 @@ static int dump_sp(struct xfrm_policy *xp, int dir, int count, void *ptr)
err = pfkey_xfrm_policy2msg(out_skb, xp, dir);
if (err < 0)
+ kfree_skb(out_skb);
return err;
out_hdr = (struct sadb_msg *) out_skb->data;
--
2.7.4
next reply other threads:[~2019-06-14 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 8:26 Young Xiao [this message]
2019-06-14 8:53 ` [PATCH] af_key: Fix memory leak in key_notify_policy Steffen Klassert
2019-06-14 9:59 ` Jeremy Sowden
2019-06-14 10:13 ` Jeremy Sowden
2019-06-14 10:17 ` Steffen Klassert
2019-06-14 10:31 ` Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560500786-572-1-git-send-email-92siuyang@gmail.com \
--to=92siuyang@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).