Netdev List
 help / color / mirror / Atom feed
From: Roman Mashak <mrv@mojatatu.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com,
	xiyou.wangcong@gmail.com, jiri@resnulli.us,
	Roman Mashak <mrv@mojatatu.com>
Subject: [PATCH net-next 0/2] Fix batched event generation for mirred action
Date: Fri, 28 Jun 2019 14:30:16 -0400	[thread overview]
Message-ID: <1561746618-29349-1-git-send-email-mrv@mojatatu.com> (raw)

When adding or deleting a batch of entries, the kernel sends upto
TCA_ACT_MAX_PRIO entries in an event to user space. However it does not
consider that the action sizes may vary and require different skb sizes.

For example :

% cat tc-batch.sh
TC="sudo /mnt/iproute2.git/tc/tc"

$TC actions flush action mirred
for i in `seq 1 $1`;
do
   cmd="action mirred egress redirect dev lo index $i "
   args=$args$cmd
done
$TC actions add $args
%
% ./tc-batch.sh 32
Error: Failed to fill netlink attributes while adding TC action.
We have an error talking to the kernel
%

patch 1 adds callback in tc_action_ops of mirred action, which calculates
the action size, and passes size to tcf_add_notify()/tcf_del_notify().

patch 2 updates the TDC test suite with relevant test cases.

Roman Mashak (2):
  net sched: update mirred action for batched events operations
  tc-testing: updated mirred action tests with batch create/delete

 net/sched/act_mirred.c                             |  6 ++
 .../tc-testing/tc-tests/actions/mirred.json        | 94 ++++++++++++++++++++++
 2 files changed, 100 insertions(+)

-- 
2.7.4


             reply	other threads:[~2019-06-28 18:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 18:30 Roman Mashak [this message]
2019-06-28 18:30 ` [PATCH net-next 1/2] net sched: update mirred action for batched events operations Roman Mashak
2019-06-28 18:30 ` [PATCH net-next 2/2] tc-testing: updated mirred action tests with batch create/delete Roman Mashak
2019-06-29 17:45 ` [PATCH net-next 0/2] Fix batched event generation for mirred action Jamal Hadi Salim
2019-07-02  2:18 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1561746618-29349-1-git-send-email-mrv@mojatatu.com \
    --to=mrv@mojatatu.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kernel@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox