Netdev List
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
	netdev@vger.kernel.org, "David Miller" <davem@davemloft.net>,
	"Jesper Dangaard Brouer" <brouer@redhat.com>,
	"Jakub Kicinski" <jakub.kicinski@netronome.com>,
	"Björn Töpel" <bjorn.topel@gmail.com>,
	"Yonghong Song" <yhs@fb.com>
Subject: [PATCH bpf-next v5 1/6] include/bpf.h: Remove map_insert_ctx() stubs
Date: Fri, 26 Jul 2019 18:06:52 +0200	[thread overview]
Message-ID: <156415721232.13581.13120224208737507294.stgit@alrua-x1> (raw)
In-Reply-To: <156415721066.13581.737309854787645225.stgit@alrua-x1>

From: Toke Høiland-Jørgensen <toke@redhat.com>

When we changed the device and CPU maps to use linked lists instead of
bitmaps, we also removed the need for the map_insert_ctx() helpers to keep
track of the bitmaps inside each map. However, it seems I forgot to remove
the function definitions stubs, so remove those here.

Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Yonghong Song <yhs@fb.com>
---
 include/linux/bpf.h |   10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/linux/bpf.h b/include/linux/bpf.h
index 18f4cc2c6acd..bfdb54dd2ad1 100644
--- a/include/linux/bpf.h
+++ b/include/linux/bpf.h
@@ -713,7 +713,6 @@ struct xdp_buff;
 struct sk_buff;
 
 struct bpf_dtab_netdev *__dev_map_lookup_elem(struct bpf_map *map, u32 key);
-void __dev_map_insert_ctx(struct bpf_map *map, u32 index);
 void __dev_map_flush(struct bpf_map *map);
 int dev_map_enqueue(struct bpf_dtab_netdev *dst, struct xdp_buff *xdp,
 		    struct net_device *dev_rx);
@@ -721,7 +720,6 @@ int dev_map_generic_redirect(struct bpf_dtab_netdev *dst, struct sk_buff *skb,
 			     struct bpf_prog *xdp_prog);
 
 struct bpf_cpu_map_entry *__cpu_map_lookup_elem(struct bpf_map *map, u32 key);
-void __cpu_map_insert_ctx(struct bpf_map *map, u32 index);
 void __cpu_map_flush(struct bpf_map *map);
 int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu, struct xdp_buff *xdp,
 		    struct net_device *dev_rx);
@@ -801,10 +799,6 @@ static inline struct net_device  *__dev_map_lookup_elem(struct bpf_map *map,
 	return NULL;
 }
 
-static inline void __dev_map_insert_ctx(struct bpf_map *map, u32 index)
-{
-}
-
 static inline void __dev_map_flush(struct bpf_map *map)
 {
 }
@@ -834,10 +828,6 @@ struct bpf_cpu_map_entry *__cpu_map_lookup_elem(struct bpf_map *map, u32 key)
 	return NULL;
 }
 
-static inline void __cpu_map_insert_ctx(struct bpf_map *map, u32 index)
-{
-}
-
 static inline void __cpu_map_flush(struct bpf_map *map)
 {
 }


  reply	other threads:[~2019-07-26 16:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-26 16:06 [PATCH bpf-next v5 0/6] xdp: Add devmap_hash map type Toke Høiland-Jørgensen
2019-07-26 16:06 ` Toke Høiland-Jørgensen [this message]
2019-07-29 15:42   ` [PATCH bpf-next v5 1/6] include/bpf.h: Remove map_insert_ctx() stubs Jesper Dangaard Brouer
2019-07-26 16:06 ` [PATCH bpf-next v5 2/6] xdp: Refactor devmap allocation code for reuse Toke Høiland-Jørgensen
2019-07-29 16:02   ` Jesper Dangaard Brouer
2019-07-26 16:06 ` [PATCH bpf-next v5 3/6] xdp: Add devmap_hash map type for looking up devices by hashed index Toke Høiland-Jørgensen
2019-07-29 16:16   ` Jesper Dangaard Brouer
2019-07-26 16:06 ` [PATCH bpf-next v5 4/6] tools/include/uapi: Add devmap_hash BPF map type Toke Høiland-Jørgensen
2019-07-29 16:16   ` Jesper Dangaard Brouer
2019-07-26 16:06 ` [PATCH bpf-next v5 5/6] tools/libbpf_probes: Add new devmap_hash type Toke Høiland-Jørgensen
2019-07-29 16:17   ` Jesper Dangaard Brouer
2019-07-26 16:06 ` [PATCH bpf-next v5 6/6] tools: Add definitions for devmap_hash map type Toke Høiland-Jørgensen
2019-07-29 16:17   ` Jesper Dangaard Brouer
2019-07-27  2:26 ` [PATCH bpf-next v5 0/6] xdp: Add " Alexei Starovoitov
2019-07-29 20:57   ` Alexei Starovoitov
2019-08-08 19:30   ` Toke Høiland-Jørgensen
2019-08-08 19:57     ` Y Song
2019-08-08 20:05       ` Jesper Dangaard Brouer
2019-08-09 18:45         ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156415721232.13581.13120224208737507294.stgit@alrua-x1 \
    --to=toke@redhat.com \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@gmail.com \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox