From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90B05C32750 for ; Tue, 13 Aug 2019 10:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B8F720665 for ; Tue, 13 Aug 2019 10:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728772AbfHMKFR (ORCPT ); Tue, 13 Aug 2019 06:05:17 -0400 Received: from mail-yw1-f66.google.com ([209.85.161.66]:32983 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728410AbfHMKFR (ORCPT ); Tue, 13 Aug 2019 06:05:17 -0400 Received: by mail-yw1-f66.google.com with SMTP id e65so2285362ywh.0; Tue, 13 Aug 2019 03:05:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QOJLmQUkpsoGCMPbck1Kq5bC18tcOyqr58P4itm/OgA=; b=ocWi80EaZD05lrd9gO5lQuxHjbRbh227mPFFH0rzjW/zmCwX9CaOo85ffTMO24cH5V SZmLHcgrgOthsyNbzC7ODH4046TeCov+qZlfpnLLrKRH5E5fH0lM8TSZpc+APubjev6q HJNfDBgKvU92O2Otdm6x9O8NwOP2HntM86Q3Qc7U33/dj/MnKWxNoDK98Eo7xnHMErCg L+qgL7+K0MOHNTZKlyOg11+ZTtobz3CKUasdTCjEmAciKM89DRQcRHMJfGDi42WXJOB2 Mnd1vrl3eWk1017o9rJ4pljIhfDYWQ0HtdtpvOhfY9YCcqS6yR/zz9datloHF/T5HmzQ YwUg== X-Gm-Message-State: APjAAAU1nBSJ/euIvCxHgCno0RslDje3K66EOBbfBv9j3Q5IddOx7hhW v8j5aD8EgB0mkriLd3BIEu0= X-Google-Smtp-Source: APXvYqwwuwtTOn9hZoDhBXnvqPqw+Qi6eA4c2mCw0sHcWfGmgnNmMD6+s+pZGJspZoJCEr12sJ53CA== X-Received: by 2002:a81:5c45:: with SMTP id q66mr13607307ywb.101.1565690715738; Tue, 13 Aug 2019 03:05:15 -0700 (PDT) Received: from localhost.localdomain (24-158-240-219.dhcp.smyr.ga.charter.com. [24.158.240.219]) by smtp.gmail.com with ESMTPSA id w206sm1485314ywc.51.2019.08.13.03.05.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 13 Aug 2019 03:05:14 -0700 (PDT) From: Wenwen Wang To: Wenwen Wang Cc: Ariel Elior , GR-everest-linux-l2@marvell.com (supporter:QLOGIC QL4xxx ETHERNET DRIVER), "David S. Miller" , netdev@vger.kernel.org (open list:QLOGIC QL4xxx ETHERNET DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] qed: Add cleanup in qed_slowpath_start() Date: Tue, 13 Aug 2019 05:05:09 -0500 Message-Id: <1565690709-3186-1-git-send-email-wenwen@cs.uga.edu> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If qed_mcp_send_drv_version() fails, no cleanup is executed, leading to memory leaks. To fix this issue, redirect the execution to the label 'err3' before returning the error. Signed-off-by: Wenwen Wang --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index 829dd60..d16a251 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -1325,7 +1325,7 @@ static int qed_slowpath_start(struct qed_dev *cdev, &drv_version); if (rc) { DP_NOTICE(cdev, "Failed sending drv version command\n"); - return rc; + goto err3; } } -- 2.7.4