From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C61C3A59E for ; Sat, 17 Aug 2019 21:05:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D16C21773 for ; Sat, 17 Aug 2019 21:05:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="JEHCNWi2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726393AbfHQVFe (ORCPT ); Sat, 17 Aug 2019 17:05:34 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:36313 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbfHQVFe (ORCPT ); Sat, 17 Aug 2019 17:05:34 -0400 Received: by mail-pl1-f195.google.com with SMTP id g4so3921385plo.3 for ; Sat, 17 Aug 2019 14:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Fp4fQXmbQWiRT3Tg1PjQ+KQDvMa3B/ngssjpquIumrY=; b=JEHCNWi2jB+byrJJK1SlV2kQX3mymcC+kU9vCfPMUbYibjLEF1XvYVDI9l6MkFP8I0 bY79QxJ9+uQsHGEcDkGDTtjeoFb2GgzYPQmdjnIYKtL8moQ8qvBORFv2ktrYiMZZgdpv XnJ/3S343L8u53Q57IJVvmPG6ueapY535rv4A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Fp4fQXmbQWiRT3Tg1PjQ+KQDvMa3B/ngssjpquIumrY=; b=ZhF/qyBxMUe2uZQXYt2bnbBpgFSc5zo3QKvzxDRvvjzgCqRYU722S/dcR5TmjW//ZB ZhCtFSsOCcDij+o9gPeaLsDzAlAsJvwBMHeU4jxIlQimMAHUP9VI9Svf97dxJAZpuU2a +vl7TCXrLBTZS2XMsv0bWPWzsyGs7lS1WUFwGEVflaEtYVIX552jbwHHJ6aWCvlwoAdz VAo2QZN4kkz0pLNSUCBv3a1FZLwzCxb0ckXpDAzjwAYM7jb5ccFszOXPoMggW2WmWVTf CKhaAaVmI8tDzgj1FV3RM7PaIcgmQ9Iq1/CaOb38L9vAwhnen0tSOuXqYTRGSJgd1g3Z OFwg== X-Gm-Message-State: APjAAAUq31jPEKQkP7sbg6VHuA0HBvffD8uqRuIEj2TCIlgB6bRzYFKC DKYw6S50GBjoClvtv0Q1DTCF1w== X-Google-Smtp-Source: APXvYqxvhAzv1bko0yd263PCMKxm+WYfpiaKqQPt9qQdxS3Ew8b57ovxy+yFJNX87nDKlRRqTfO12g== X-Received: by 2002:a17:902:a607:: with SMTP id u7mr15577128plq.43.1566075933648; Sat, 17 Aug 2019 14:05:33 -0700 (PDT) Received: from localhost.swdvt.lab.broadcom.com ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id e189sm9099295pgc.15.2019.08.17.14.05.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Aug 2019 14:05:33 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, Vasundhara Volam Subject: [PATCH net v2 4/6] bnxt_en: Suppress HWRM errors for HWRM_NVM_GET_VARIABLE command Date: Sat, 17 Aug 2019 17:04:50 -0400 Message-Id: <1566075892-30064-5-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1566075892-30064-1-git-send-email-michael.chan@broadcom.com> References: <1566075892-30064-1-git-send-email-michael.chan@broadcom.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vasundhara Volam For newly added NVM parameters, older firmware may not have the support. Suppress the error message to avoid the unncessary error message which is triggered when devlink calls the driver during initialization. Fixes: 782a624d00fa ("bnxt_en: Add bnxt_en initial params table and register it.") Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c index 549c90d3..c05d663 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c @@ -98,10 +98,13 @@ static int bnxt_hwrm_nvm_req(struct bnxt *bp, u32 param_id, void *msg, if (idx) req->dimensions = cpu_to_le16(1); - if (req->req_type == cpu_to_le16(HWRM_NVM_SET_VARIABLE)) + if (req->req_type == cpu_to_le16(HWRM_NVM_SET_VARIABLE)) { memcpy(data_addr, buf, bytesize); - - rc = hwrm_send_message(bp, msg, msg_len, HWRM_CMD_TIMEOUT); + rc = hwrm_send_message(bp, msg, msg_len, HWRM_CMD_TIMEOUT); + } else { + rc = hwrm_send_message_silent(bp, msg, msg_len, + HWRM_CMD_TIMEOUT); + } if (!rc && req->req_type == cpu_to_le16(HWRM_NVM_GET_VARIABLE)) memcpy(buf, data_addr, bytesize); -- 2.5.1