From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7928C3A5A0 for ; Wed, 21 Aug 2019 09:56:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 984D32332A for ; Wed, 21 Aug 2019 09:56:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726843AbfHUJ4Q (ORCPT ); Wed, 21 Aug 2019 05:56:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:44444 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726388AbfHUJ4P (ORCPT ); Wed, 21 Aug 2019 05:56:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 648B7AE21; Wed, 21 Aug 2019 09:56:14 +0000 (UTC) Message-ID: <1566380491.8347.13.camel@suse.com> Subject: Re: [RFC 0/4] Add support into cdc_ncm for MAC address pass through From: Oliver Neukum To: Charles.Hyde@dellteam.com, linux-acpi@vger.kernel.org, linux-usb@vger.kernel.org Cc: Mario.Limonciello@dell.com, gregkh@linuxfoundation.org, nic_swsd@realtek.com, netdev@vger.kernel.org Date: Wed, 21 Aug 2019 11:41:31 +0200 In-Reply-To: <89a5f8ea30b240babd8750d236ca9ef4@AUSX13MPS303.AMER.DELL.COM> References: <89a5f8ea30b240babd8750d236ca9ef4@AUSX13MPS303.AMER.DELL.COM> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am Dienstag, den 20.08.2019, 22:15 +0000 schrieb Charles.Hyde@dellteam.com: > In recent testing of a Dell Universal Dock D6000, I found that MAC address pass through is not supported in the Linux drivers. Hi, thank you for writing this code. It adds cool functionality. There are, however, a few design issues and minor flaws with it. I will comment on the patches in the series to point them out. Could you correct them? Regards Oliver