From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89CDCC3A5A2 for ; Tue, 3 Sep 2019 15:42:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F12E2077B for ; Tue, 3 Sep 2019 15:42:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="EzcjS1ne" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729790AbfICPmZ (ORCPT ); Tue, 3 Sep 2019 11:42:25 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:36980 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729630AbfICPmZ (ORCPT ); Tue, 3 Sep 2019 11:42:25 -0400 Received: by mail-qt1-f194.google.com with SMTP id y26so20505627qto.4 for ; Tue, 03 Sep 2019 08:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=EHMZPUP68y2z5iguVqfzfNFlYo+Wg20UbTwXQGqtd0o=; b=EzcjS1ne4C9CO1P3CFCR3w0b95IZNPd6WLZr0ngkGQpYO3cX3IyLFr+dohcEyQLsns SwiDwwkeIYFf7VUVU35KLiQv93fjflQ44R93x0WULpKB+q7gsueMZiVGyxBXgsNmsQv9 7sQsKdTDOxerv9Ll27PozXLJKKOuv0XM0eSXw0EGjeFTqH4pXSYcLealkPpszkzwHYW5 2si2Cply4cTtIYbVZ9v8aAhWY50BSs1yApFvgqenwcn1hTxY30s5LcRLk2GsZwhaVqtp FzaGA+tBBm85RAOhG/PhDnSFMeq2OfGk7wzz0ZZ9iLycsN2ny7PDQd6MvO1im0waXF/f oH8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=EHMZPUP68y2z5iguVqfzfNFlYo+Wg20UbTwXQGqtd0o=; b=CI11Gz7OeLyaxV7Z3CHSCi9WiPEVENrR+x5Nzl/5H7do82KwgW93/05euZCn/QPI7j ZH0ahPoU8SzfGKPni2FHz++XvSQLUvMybTVNJiR0q0aMoqCiq40ZFIgVM1Y9fuzytj+a 6BBIzpdRKX2J8+nw9z9t2YroTcuahgiBkCYg4+NpNkC8yYgs0Oevo1HI0vMBQpynI5yL nGbttT5/CB4dZq/7VFJxGCu0dTbD+bwBB5dzB09DYwuWmfoSThGixqG3DqJ/QtDAQovJ Y4u3Ljtugup3Rk27uE0pMcg3OZdKvQnNUFaUL208vRN41vnkNNUhEnzik2fwLQDUp35C x+ug== X-Gm-Message-State: APjAAAUEeVytXK1i3LgBEqzq8qv1Lcz10Y3KbjT8IaLa/SV+Oo1wzkGA QX864XtkGpXIZGmSOwSRK/WBQw== X-Google-Smtp-Source: APXvYqw+IwNKrHV+dGx3RobeKrDl8nlXyE0LPhn/oZzdxlaGBn0SEZqwK+nCGwY7RbgaekZ6W8Fyhg== X-Received: by 2002:ac8:92d:: with SMTP id t42mr7369525qth.206.1567525344750; Tue, 03 Sep 2019 08:42:24 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id f83sm841590qke.80.2019.09.03.08.42.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Sep 2019 08:42:24 -0700 (PDT) Message-ID: <1567525342.5576.60.camel@lca.pw> Subject: Re: [PATCH] net/skbuff: silence warnings under memory pressure From: Qian Cai To: Michal Hocko , Eric Dumazet Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Tue, 03 Sep 2019 11:42:22 -0400 In-Reply-To: <20190903132231.GC18939@dhcp22.suse.cz> References: <1567177025-11016-1-git-send-email-cai@lca.pw> <6109dab4-4061-8fee-96ac-320adf94e130@gmail.com> <1567178728.5576.32.camel@lca.pw> <229ebc3b-1c7e-474f-36f9-0fa603b889fb@gmail.com> <20190903132231.GC18939@dhcp22.suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2019-09-03 at 15:22 +0200, Michal Hocko wrote: > On Fri 30-08-19 18:15:22, Eric Dumazet wrote: > > If there is a risk of flooding the syslog, we should fix this generically > > in mm layer, not adding hundred of __GFP_NOWARN all over the places. > > We do already ratelimit in warn_alloc. If it isn't sufficient then we > can think of a different parameters. Or maybe it is the ratelimiting > which doesn't work here. Hard to tell and something to explore. The time-based ratelimit won't work for skb_build() as when a system under memory pressure, and the CPU is fast and IO is so slow, it could take a long time to swap and trigger OOM. I suppose what happens is those skb_build() allocations are from softirq, and once one of them failed, it calls printk() which generates more interrupts. Hence, the infinite loop.