From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from smtp-36-i2.italiaonline.it ([213.209.12.36]:40377 "EHLO
        libero.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752689AbeCVOMv (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 22 Mar 2018 10:12:51 -0400
Date: Thu, 22 Mar 2018 15:12:49 +0100 (CET)
From: Marco Berizzi <pupilla@libero.it>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>
Message-ID: <15688407.84941.1521727969769@mail.libero.it>
In-Reply-To: <11d36e94-0b07-425d-78d1-dd41b60a586f@mojatatu.com>
References: <1235741366.800982.1520441932561@mail.libero.it>
 <746588000.720568.1520524944312@mail.libero.it>
 <CAM_iQpWBo2A4dNpPmocgKd-cHm=gHR_hvS=pqmtEm=EhvcfLRQ@mail.gmail.com>
 <495487313.1094743.1521015026754@mail.libero.it>
 <CAM_iQpX5c6QoRZ8+oxs3P0TLwfjh2DTu4R8vUtOY8rYyweXRLQ@mail.gmail.com>
 <11d36e94-0b07-425d-78d1-dd41b60a586f@mojatatu.com>
Subject: Re: WARNING: CPU: 3 PID: 0 at net/sched/sch_hfsc.c:1388
 hfsc_dequeue+0x319/0x350 [sch_hfsc]
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Il 19 marzo 2018 alle 11.07 Jamal Hadi Salim <jhs@mojatatu.com> ha scritto:
> 
> On 18-03-15 08:48 PM, Cong Wang wrote:
> 
> > On Wed, Mar 14, 2018 at 1:10 AM, Marco Berizzi <pupilla@libero.it> wrote:
> > 
> > > > Il 9 marzo 2018 alle 0.14 Cong Wang <xiyou.wangcong@gmail.com> ha scritto:
> > > > 
> > > > On Thu, Mar 8, 2018 at 8:02 AM, Marco Berizzi <pupilla@libero.it> wrote:
> > > > 
> > > > > > Marco Berizzi wrote:
> > > > > > 
> > > > > > Hello everyone,
> > > > > > 
> > > > > > Yesterday I got this error on a slackware linux 4.16-rc4 system
> > > > > > running as a traffic shaping gateway and netfilter nat.
> > > > > > The error has been arisen after a partial ISP network outage,
> > > > > > so unfortunately it will not trivial for me to reproduce it again.
> > > > > 
> > > > > Hello everyone,
> > > > > 
> > > > > I'm getting this error twice/day, so fortunately I'm able to
> > > > > reproduce it.
> > > > 
> > > > IIRC, there was a patch for this, but it got lost...
> > > > 
> > > > I will take a look anyway.
> > > 
> > > ok, thanks for the response. Let me know when there will be a patch
> > > available to test.
> > 
> > It has been reported here:
> > https://bugzilla.kernel.org/show_bug.cgi?id=109581
> > 
> > And there is a workaround from Konstantin:
> > https://patchwork.ozlabs.org/patch/803885/
> > 
> > Unfortunately I don't think that is a real fix, we probably need to
> > fix HFSC itself rather than just workaround the qlen==0. It is not
> > trivial since HFSC implementation is not easy to understand.
> > Maybe Jamal knows better than me.
> 
> Sorry for the latency - I looked at this on the plane and it is very
> specific to fq/codel. It is not clear to me why codel needs this but
> i note it has been there from the initial commit and from that
> perspective the patch looks reasonable. In any case:
> Punting it to Eric (on Cc).

Hello everyone,

just for ask: it there any luck to get this patch before 4.16 final?