Netdev List
 help / color / mirror / Atom feed
From: xiangxia.m.yue@gmail.com
To: pshelar@ovn.org, gvrose8192@gmail.com
Cc: netdev@vger.kernel.org, Tonghao Zhang <xiangxia.m.yue@gmail.com>
Subject: [PATCH net-next 7/7] net: openvswitch: add likely in flow_lookup
Date: Fri, 20 Sep 2019 00:54:53 +0800	[thread overview]
Message-ID: <1568912093-68535-8-git-send-email-xiangxia.m.yue@gmail.com> (raw)
In-Reply-To: <1568912093-68535-1-git-send-email-xiangxia.m.yue@gmail.com>

From: Tonghao Zhang <xiangxia.m.yue@gmail.com>

The most case *index < ma->max, we add likely for performance.

Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
 net/openvswitch/flow_table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c
index 223470a..bd7e976 100644
--- a/net/openvswitch/flow_table.c
+++ b/net/openvswitch/flow_table.c
@@ -526,7 +526,7 @@ static struct sw_flow *flow_lookup(struct flow_table *tbl,
 	struct sw_flow_mask *mask;
 	int i;
 
-	if (*index < ma->max) {
+	if (likely(*index < ma->max)) {
 		mask = rcu_dereference_ovsl(ma->masks[*index]);
 		if (mask) {
 			flow = masked_flow_lookup(ti, key, mask, n_mask_hit);
-- 
1.8.3.1


  parent reply	other threads:[~2019-09-26  8:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 16:54 [PATCH net-next 0/7] optimize openvswitch flow looking up xiangxia.m.yue
2019-09-19 16:54 ` [PATCH net-next 1/7] net: openvswitch: add flow-mask cache for performance xiangxia.m.yue
2019-09-19 16:54 ` [PATCH net-next 2/7] net: openvswitch: convert mask list in mask array xiangxia.m.yue
2019-09-19 16:54 ` [PATCH net-next 3/7] net: openvswitch: shrink the mask array if necessary xiangxia.m.yue
2019-09-19 16:54 ` [PATCH net-next 4/7] net: openvswitch: optimize flow mask cache hash collision xiangxia.m.yue
2019-09-19 16:54 ` [PATCH net-next 5/7] net: openvswitch: optimize flow-mask looking up xiangxia.m.yue
2019-09-19 16:54 ` [PATCH net-next 6/7] net: openvswitch: simplify the flow_hash xiangxia.m.yue
2019-09-19 16:54 ` xiangxia.m.yue [this message]
2019-09-26 10:14 ` [PATCH net-next 0/7] optimize openvswitch flow looking up David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1568912093-68535-8-git-send-email-xiangxia.m.yue@gmail.com \
    --to=xiangxia.m.yue@gmail.com \
    --cc=gvrose8192@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@ovn.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox