From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3570BC47404 for ; Wed, 9 Oct 2019 14:16:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E81D218AC for ; Wed, 9 Oct 2019 14:16:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=pixelbox.red header.i=@pixelbox.red header.b="tpKjI8Ez" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731083AbfJIOQP (ORCPT ); Wed, 9 Oct 2019 10:16:15 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.25]:27585 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729491AbfJIOQO (ORCPT ); Wed, 9 Oct 2019 10:16:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1570630570; s=strato-dkim-0002; d=pixelbox.red; h=Message-Id:Date:Subject:Cc:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=XSSL21NdaClI94p1jn2W9ASCiLNEtcEZcSQFd9LgbO4=; b=tpKjI8EzDBgjnHsnCMlh4+J3Faho3LhjZLW5D0A4mA+0+NNg2dVb0Y00kSR8L59j+Y dZzYBhbGXHXW6o2xscgZTtT5nPTqzDpmBcIIUESF5wNw5C8NkLqVLSRE0oO6/v8yuXvm r900DYdgZsZWqEarK9XP1k5zGFMJDkI0YIPqH8UkH8OdTuGKyhT+0d8cgXtWd2UNJrQi awnd4N9vbID+VmyLV9mvpxWuGTRsjqcTfAqewZCwJye7jVeHB4sw26AhnfTVtrZowRDS cVSjt8sAgcGDC5u9dpiVYybU89rtoiR+TVpJpX2za6EzcaSo0vsaBL8y86fTOKeg3CLk WClA== X-RZG-AUTH: ":PGkAZ0+Ia/aHbZh+i/9QzqYeH5BDcTFH98iPmzDT881S1Jv9Y40I0vUpkEK3poY1KyL7e8vwUVd6rhLT+3nQPD/JTWrS4IlCVOSV0M8=" X-RZG-CLASS-ID: mo00 Received: from localhost.localdomain by smtp.strato.de (RZmta 44.28.0 AUTH) with ESMTPSA id d0520cv99EG5lyf (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Wed, 9 Oct 2019 16:16:05 +0200 (CEST) From: Peter Fink To: netdev@vger.kernel.org Cc: pfink@christ-es.de, davem@davemloft.net Subject: [PATCH net-next] net: usb: ax88179_178a: write mac to hardware in get_mac_addr Date: Wed, 9 Oct 2019 16:15:49 +0200 Message-Id: <1570630549-23976-1-git-send-email-pedro@pixelbox.red> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Peter Fink When the MAC address is supplied via device tree or a random MAC is generated it has to be written to the asix chip in order to receive any data. In the previous commit (9fb137a) this line was omitted because it seemed to work perfectly fine without it. But it was simply not detected because the chip keeps the mac stored even beyond a reset and it was tested on a hardware with an integrated UPS where the asix chip was permanently powered on even throughout power cycles. Signed-off-by: Peter Fink --- drivers/net/usb/ax88179_178a.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 5a58766..c5a6e75 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1235,6 +1235,9 @@ static void ax88179_get_mac_addr(struct usbnet *dev) netdev_info(dev->net, "invalid MAC address, using random\n"); eth_hw_addr_random(dev->net); } + + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN, + dev->net->dev_addr); } static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) -- 2.7.4