netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Berger <opendmb@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Doug Berger <opendmb@gmail.com>
Subject: [PATCH net 0/4] net: bcmgenet: restore internal EPHY support
Date: Wed, 16 Oct 2019 16:06:28 -0700	[thread overview]
Message-ID: <1571267192-16720-1-git-send-email-opendmb@gmail.com> (raw)

I managed to get my hands on an old BCM97435SVMB board to do some
testing with the latest kernel and uncovered a number of things
that managed to get broken over the years (some by me ;).

This commit set attempts to correct the errors I observed in my
testing.

The first commit applies to all internal PHYs to restore proper
reporting of link status when a link comes up.

The second commit restores the soft reset to the initialization of
the older internal EPHYs used by 40nm Set-Top Box devices.

The third corrects a bug I introduced when removing excessive soft
resets by altering the initialization sequence in a way that keeps
the GENETv3 MAC interface happy.

Finally, I observed a number of issues when manually configuring
the network interface of the older EPHYs that appear to be resolved
by the fourth commit.

Doug Berger (4):
  net: bcmgenet: don't set phydev->link from MAC
  net: phy: bcm7xxx: define soft_reset for 40nm EPHY
  net: bcmgenet: soft reset 40nm EPHYs before MAC init
  net: bcmgenet: reset 40nm EPHY on energy detect

 drivers/net/ethernet/broadcom/genet/bcmgenet.c |  41 +++++----
 drivers/net/ethernet/broadcom/genet/bcmgenet.h |   2 +-
 drivers/net/ethernet/broadcom/genet/bcmmii.c   | 112 +++++++++++--------------
 drivers/net/phy/bcm7xxx.c                      |   1 +
 4 files changed, 79 insertions(+), 77 deletions(-)

-- 
2.7.4


             reply	other threads:[~2019-10-16 23:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 23:06 Doug Berger [this message]
2019-10-16 23:06 ` [PATCH net 1/4] net: bcmgenet: don't set phydev->link from MAC Doug Berger
2019-10-17  3:50   ` Florian Fainelli
2019-10-16 23:06 ` [PATCH net 2/4] net: phy: bcm7xxx: define soft_reset for 40nm EPHY Doug Berger
2019-10-17  3:53   ` Florian Fainelli
2019-10-16 23:06 ` [PATCH net 3/4] net: bcmgenet: soft reset 40nm EPHYs before MAC init Doug Berger
2019-10-17  3:53   ` Florian Fainelli
2019-10-31 18:57     ` Doug Berger
2019-10-16 23:06 ` [PATCH net 4/4] net: bcmgenet: reset 40nm EPHY on energy detect Doug Berger
2019-10-17  3:56   ` Florian Fainelli
2019-10-17  4:00 ` [PATCH net 0/4] net: bcmgenet: restore internal EPHY support Florian Fainelli
2019-10-18 17:01 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1571267192-16720-1-git-send-email-opendmb@gmail.com \
    --to=opendmb@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).