From: Landen Chao <landen.chao@mediatek.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"vivien.didelot@savoirfairelinux.com"
<vivien.didelot@savoirfairelinux.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Sean Wang <Sean.Wang@mediatek.com>,
"opensource@vdorst.com" <opensource@vdorst.com>,
"frank-w@public-files.de" <frank-w@public-files.de>
Subject: Re: [PATCH net-next 3/6] dt-bindings: net: dsa: add new MT7531 binding to support MT7531
Date: Wed, 11 Dec 2019 22:10:44 +0800 [thread overview]
Message-ID: <1576073444.23763.11.camel@mtksdccf07> (raw)
In-Reply-To: <20191210162010.GB27714@lunn.ch>
Hi Andrew,
On Wed, 2019-12-11 at 00:20 +0800, Andrew Lunn wrote:
> > +Example 4:
> > +
> > +ð {
> > + gmac0: mac@0 {
> > + compatible = "mediatek,eth-mac";
> > + reg = <0>;
> > + phy-mode = "2500base-x";
> > +
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + pause;
> > + };
> > + };
>
> 2500Base-X, but fixed link speed 1000?
fixed-link speed should be 2500. I will update it.
>
> > + port@6 {
> > + reg = <6>;
> > + label = "cpu";
> > + ethernet = <&gmac0>;
> > + phy-mode = "2500base-x";
> > +
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + pause;
> > + };
>
> Same here!
I will update it or remove fixed-link block as the discussion in dts
thread.
>
> Andrew
regards Landen
next prev parent reply other threads:[~2019-12-11 14:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 8:14 [PATCH net-next 0/6] net-next: dsa: mt7530: add support for MT7531 Landen Chao
2019-12-10 8:14 ` [PATCH net-next 1/6] net: dsa: mt7530: Refine message in Kconfig Landen Chao
2019-12-12 3:41 ` Florian Fainelli
2019-12-10 8:14 ` [PATCH net-next 2/6] net: dsa: mt7530: Extend device data ready for adding a new hardware Landen Chao
2019-12-12 3:45 ` Florian Fainelli
2019-12-12 15:03 ` Landen Chao
2019-12-12 15:05 ` Landen Chao
2019-12-10 8:14 ` [PATCH net-next 3/6] dt-bindings: net: dsa: add new MT7531 binding to support MT7531 Landen Chao
2019-12-10 16:20 ` Andrew Lunn
2019-12-11 14:10 ` Landen Chao [this message]
2019-12-12 3:46 ` Florian Fainelli
2019-12-10 8:14 ` [PATCH net-next 4/6] net: dsa: mt7530: Add the support of MT7531 switch Landen Chao
2019-12-10 16:35 ` Andrew Lunn
2019-12-10 17:05 ` Vladimir Oltean
2019-12-10 20:33 ` Marek Behun
2019-12-10 22:02 ` Andrew Lunn
2019-12-11 17:35 ` Landen Chao
2019-12-10 16:44 ` Andrew Lunn
2019-12-11 18:18 ` Landen Chao
2019-12-11 19:27 ` Andrew Lunn
2019-12-12 15:04 ` Landen Chao
2019-12-10 16:48 ` Andrew Lunn
2019-12-11 17:48 ` Landen Chao
2019-12-12 3:57 ` Florian Fainelli
2019-12-12 16:24 ` Landen Chao
2019-12-10 8:14 ` [PATCH net-next 5/6] arm64: dts: mt7622: add mt7531 dsa to mt7622-rfb1 board Landen Chao
2019-12-10 16:51 ` Andrew Lunn
2019-12-11 18:27 ` Landen Chao
2019-12-10 8:14 ` [PATCH net-next 6/6] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board Landen Chao
2019-12-10 11:37 ` Aw: [PATCH net-next 0/6] net-next: dsa: mt7530: add support for MT7531 Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1576073444.23763.11.camel@mtksdccf07 \
--to=landen.chao@mediatek.com \
--cc=Sean.Wang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opensource@vdorst.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).