From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC09D329E65 for ; Mon, 5 Jan 2026 08:23:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767601424; cv=none; b=SxtKECl6IbTqz5aJUH5yviOmYP5tFs1AKinVsi37U386xfSQy94erHT5vjDBwTkl67ssv8wbqIxqScQYqa6q1I7/C6HsjvWSUJbYG7ALFaCFRZCmWVglZDRCLl11YzzniOGeUKeashjzMa3i8haqC/48rZPSTV3/7y1SvRMIvSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767601424; c=relaxed/simple; bh=HzYnyY7SZLB21Zw4R22hNRsG3Q5nx5zt5Jv7qf1jNBQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c/jhj6UkWBS8PPO6Ew+OmkpVOersRTaI+Pu6xceirs/B4nExD6fb2SKBo/sRQqlA/x/sl7V3NWxxGDN/7w164yCK5GNpfZlTup4kkNeHkjq3+H1ZM8/hzfoPYrG8yUKCelh0PViuhJ4SPV+60n9FqbfB2o8nOQijJvPyXL9zcnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MgC04sXg; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=I5yswi6H; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MgC04sXg"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="I5yswi6H" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767601419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/8txVkwqMRJjWWbc/atl6vQI7/U+u3Ckdz87v1ZTBF4=; b=MgC04sXgf8rO8jgoBcTf5yOx5jIhDb8GlRitaZ/HquEy+iKOs64UIdMxdqvdhpOmTj9yBF 6eHfYOSIzrSABG40Ek7+ncR/kLkToMiUkzW0r0hQe+jGiBO1+n2Jc6oi3cLJT+CznXbyJR cy+XSYVYVMPvbVGf89ZsBHzj4b6E5q4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-Ytp_wX3CMOWYfeTOVDfXUw-1; Mon, 05 Jan 2026 03:23:38 -0500 X-MC-Unique: Ytp_wX3CMOWYfeTOVDfXUw-1 X-Mimecast-MFC-AGG-ID: Ytp_wX3CMOWYfeTOVDfXUw_1767601417 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4775d8428e8so117043605e9.0 for ; Mon, 05 Jan 2026 00:23:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767601417; x=1768206217; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/8txVkwqMRJjWWbc/atl6vQI7/U+u3Ckdz87v1ZTBF4=; b=I5yswi6HKFYmnvSvPTgX5I5GufkEjc88XVQp3JUswvb1KOQoqFcAzdQNWr4rLb2KtD w6kIV8i8HddwgY5dtR/atqlL0npCMlNrnonS9ZdFWUmUsJNnipDt3dUq/RehUuzNtFKZ x5OW/C5dHDyI9O+FOhKrbHes3aKeeS7QkT69Z91lgPSyaHBGhFQGkpBw1W8/eSTGQ1Mg EDojgVrRxwjobAMfRWdQbWUyMx2jYCWo61MzPIA7KgyJT6RQuzNJiNMJln+XK11k36rs Qq9gn0iPDciYwO3esIO4tkuPZUbpAQyEqyFijEJ8x3C885jkQqOn0Q6CcbSXPpAJ9nhT X19g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767601417; x=1768206217; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/8txVkwqMRJjWWbc/atl6vQI7/U+u3Ckdz87v1ZTBF4=; b=SBpGT7huMhclj5rCCAUxO9g97w6K390GNzyg5ZYHN5Ih9gVfBIS14LBHlGRWO0+gGd Nvl1zDAhwN2mvrxS1n7akusYhO/eGxK8uAHF/4gHlMj6QdQ9qnyfuG06wjmP5qngA00B m7I5FSBQq2H/YkT+PM+jXzVVxEk2MhxpQOSRMJ5CoLSg7T0EzDUGVIUN6QwP7XT3HT9F nSdKnXFO9UJqBQmab2xQNIw6u13GLvRj8RdC3TMYfT3M2WIoGN0ghWzzMFiG7Mrw5utv j7dsQRPX/bbwOgGpsgjsRX2TigekWLitYeNc5BGKFqAeC070RmqRGdP0KJj3URxslQny H+7g== X-Forwarded-Encrypted: i=1; AJvYcCWxNCzyeYBRnas/BSz0cNP5OgyDklcHL7EyXRIkhZ1TkwCaKeHfySQrRXdJTPl9ON4e/wcutyM=@vger.kernel.org X-Gm-Message-State: AOJu0YwlQ91l9xOBikZs8CIZ35xRcJiew8pnKKq9VAp9O2GSZqwTUi37 mj9TBV0OEyOl99Inkb4DdtymjLE4H5MAPYJB1l7lFD/n2ULDwMJire3cMiA2BpNPw5KyfYw1Pkx mRng3dp8wkcZdYdlPfVwjmgY1V6bo+vHY9gfUmXbFRXW51u86PrfRrhvNpA== X-Gm-Gg: AY/fxX5IAfoTQwHxYNo88cyqvW2IrfMfxMr2l0JTdKFhFUCjvEalZVc3MjlMSwIW2YF zbhr7D9lNT8t19Zmf1sF9wrjYQ72fHWQ32QlJEumIiYQPTHw0dGgF0IXn1+bOKFWaNLP8EJIApG Z2XENz7E3kj45T3Qh/ZWYPGrQf0lyLipeks3QguLb0ShQ0UJ7Nm+ctWf5EtiVFkIj2QIMWt7/48 96x9jgxcxF0myBqJPoy6KChOKfCmA7dphV+MozCcBeLQz4Xte5xVmTXa5u51rU7bpbQKEsYauP3 MdP3MaP+fnSfaNQy08Fe2eSVbDX6ODzRBYBpBfp+oouOck2HAAmgBRx2UhmvNZbFyKSF5ezvIPD yniyhoucfxEdCrRvyhbVNnI7Cj52ZRnxgyg== X-Received: by 2002:a05:600c:858e:b0:46f:c55a:5a8d with SMTP id 5b1f17b1804b1-47d1c629902mr472043505e9.4.1767601417351; Mon, 05 Jan 2026 00:23:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHVSX2iBXTT4S7tXy0ZYHsUHRdZMVGE7PsYbGyf8OKqSDfiJqG7TGaTn+6DDGk03BIi3LI2pg== X-Received: by 2002:a05:600c:858e:b0:46f:c55a:5a8d with SMTP id 5b1f17b1804b1-47d1c629902mr472043065e9.4.1767601416846; Mon, 05 Jan 2026 00:23:36 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d6be6b202sm54210025e9.6.2026.01.05.00.23.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 00:23:36 -0800 (PST) Date: Mon, 5 Jan 2026 03:23:33 -0500 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?utf-8?B?UMOpcmV6?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Petr Tesarik , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 11/15] virtio-rng: fix DMA alignment for data buffer Message-ID: <157a63b6324d1f1307ddd4faa3b62a8b90a79423.1767601130.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent The data buffer in struct virtrng_info is used for DMA_FROM_DEVICE via virtqueue_add_inbuf() and shares cachelines with the adjacent CPU-written fields (data_avail, data_idx). The device writing to the DMA buffer and the CPU writing to adjacent fields could corrupt each other's data on non-cache-coherent platforms. Add __dma_from_device_group_begin()/end() annotations to place these in distinct cache lines. Signed-off-by: Michael S. Tsirkin --- drivers/char/hw_random/virtio-rng.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c index dd998f4fe4f2..eb80a031c7be 100644 --- a/drivers/char/hw_random/virtio-rng.c +++ b/drivers/char/hw_random/virtio-rng.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include @@ -28,11 +29,13 @@ struct virtrng_info { unsigned int data_avail; unsigned int data_idx; /* minimal size returned by rng_buffer_size() */ + __dma_from_device_group_begin(); #if SMP_CACHE_BYTES < 32 u8 data[32]; #else u8 data[SMP_CACHE_BYTES]; #endif + __dma_from_device_group_end(); }; static void random_recv_done(struct virtqueue *vq) -- MST