From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Jarod Wilson <jarod@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next] bonding: add new option lacp_active
Date: Thu, 29 Jul 2021 10:14:14 -0700 [thread overview]
Message-ID: <15810.1627578854@famine> (raw)
In-Reply-To: <YQIMay98k1OjAmjm@Laptop-X1>
Hangbin Liu <liuhangbin@gmail.com> wrote:
>On Wed, Jul 28, 2021 at 12:10:38PM -0700, Jay Vosburgh wrote:
>> Jiri Pirko <jiri@resnulli.us> wrote:
>>
>> >Wed, Jul 28, 2021 at 11:52:29AM CEST, liuhangbin@gmail.com wrote:
>> >
>> >[...]
>> >
>> >>+module_param(lacp_active, int, 0);
>> >>+MODULE_PARM_DESC(lacp_active, "Send LACPDU frames as the configured lacp_rate or acts as speak when spoken to; "
>> >>+ "0 for off, 1 for on (default)");
>> >
>> >Afaik adding module parameters is not allowed.
>>
>> Correct; also, adding options requires adding support to
>> iproute2 to handle the new options via netlink.
>
>Hi Jay, Jiri,
>
>Thanks for this info. I will remove the module param. For iproute2, I already
>have a patch to support this options. I planed to post it after the
>kernel patch applied.
Please post the iproute2 patch at the same time as the new
option patch.
-J
---
-Jay Vosburgh, jay.vosburgh@canonical.com
prev parent reply other threads:[~2021-07-29 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 9:52 [PATCH net-next] bonding: add new option lacp_active Hangbin Liu
2021-07-28 13:56 ` Jiri Pirko
2021-07-28 19:10 ` Jay Vosburgh
2021-07-29 2:03 ` Hangbin Liu
2021-07-29 17:14 ` Jay Vosburgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15810.1627578854@famine \
--to=jay.vosburgh@canonical.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=jarod@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).