netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pengcheng Yang <yangpc@wangsu.com>
To: edumazet@google.com, ncardwell@google.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Pengcheng Yang <yangpc@wangsu.com>
Subject: [PATCH RESEND net-next v2 4/5] tcp: fix stretch ACK bugs in Veno
Date: Mon, 16 Mar 2020 14:35:10 +0800	[thread overview]
Message-ID: <1584340511-9870-5-git-send-email-yangpc@wangsu.com> (raw)
In-Reply-To: <1584340511-9870-1-git-send-email-yangpc@wangsu.com>

Change Veno to properly handle stretch ACKs in additive
increase mode by passing in the count of ACKed packets
to tcp_cong_avoid_ai().

Signed-off-by: Pengcheng Yang <yangpc@wangsu.com>
---
 net/ipv4/tcp_veno.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/net/ipv4/tcp_veno.c b/net/ipv4/tcp_veno.c
index 857491c..50a9a6e 100644
--- a/net/ipv4/tcp_veno.c
+++ b/net/ipv4/tcp_veno.c
@@ -154,8 +154,9 @@ static void tcp_veno_cong_avoid(struct sock *sk, u32 ack, u32 acked)
 
 		if (tcp_in_slow_start(tp)) {
 			/* Slow start. */
-			tcp_slow_start(tp, acked);
-			goto done;
+			acked = tcp_slow_start(tp, acked);
+			if (!acked)
+				goto done;
 		}
 
 		/* Congestion avoidance. */
@@ -163,7 +164,7 @@ static void tcp_veno_cong_avoid(struct sock *sk, u32 ack, u32 acked)
 			/* In the "non-congestive state", increase cwnd
 			 * every rtt.
 			 */
-			tcp_cong_avoid_ai(tp, tp->snd_cwnd, 1);
+			tcp_cong_avoid_ai(tp, tp->snd_cwnd, acked);
 		} else {
 			/* In the "congestive state", increase cwnd
 			 * every other rtt.
@@ -177,7 +178,7 @@ static void tcp_veno_cong_avoid(struct sock *sk, u32 ack, u32 acked)
 					veno->inc = 1;
 				tp->snd_cwnd_cnt = 0;
 			} else
-				tp->snd_cwnd_cnt++;
+				tp->snd_cwnd_cnt += acked;
 		}
 done:
 		if (tp->snd_cwnd < 2)
-- 
1.8.3.1


  parent reply	other threads:[~2020-03-16  6:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16  6:35 [PATCH RESEND net-next v2 0/5] tcp: fix stretch ACK bugs in congestion control modules Pengcheng Yang
2020-03-16  6:35 ` [PATCH RESEND net-next v2 1/5] tcp: fix stretch ACK bugs in BIC Pengcheng Yang
2020-03-16 21:19   ` Neal Cardwell
2020-03-16  6:35 ` [PATCH RESEND net-next v2 2/5] tcp: fix stretch ACK bugs in Scalable Pengcheng Yang
2020-03-16 21:25   ` Neal Cardwell
2020-03-16  6:35 ` [PATCH RESEND net-next v2 3/5] tcp: stretch ACK fixes in Veno prep Pengcheng Yang
2020-03-16 21:42   ` Neal Cardwell
2020-03-16  6:35 ` Pengcheng Yang [this message]
2020-03-16 21:46   ` [PATCH RESEND net-next v2 4/5] tcp: fix stretch ACK bugs in Veno Neal Cardwell
2020-03-16  6:35 ` [PATCH RESEND net-next v2 5/5] tcp: fix stretch ACK bugs in Yeah Pengcheng Yang
2020-03-17  1:27 ` [PATCH RESEND net-next v2 0/5] tcp: fix stretch ACK bugs in congestion control modules David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1584340511-9870-5-git-send-email-yangpc@wangsu.com \
    --to=yangpc@wangsu.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).