From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD743C54FCB for ; Thu, 23 Apr 2020 14:58:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 973C42074F for ; Thu, 23 Apr 2020 14:58:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MqJDM0sL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728906AbgDWO6B (ORCPT ); Thu, 23 Apr 2020 10:58:01 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:53772 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726380AbgDWO6B (ORCPT ); Thu, 23 Apr 2020 10:58:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587653880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ar8j2PHfeuXeYPYrQeghbkoLa2HxMcG2vDet8SSgbl0=; b=MqJDM0sLLkj3p3ctWY6fDk9ISVxdESYBoUR9mRxaNazKtHioEZoxjJU5j/mphm71Wbn99Z NLjrOCHAwQ+eJy/HG747fWpIwyN01fDQIomR9V70QG2sUsY1U1ld8+cA89z7AV2Q4KRzsh UxOGiOhk2jaimCv82JXBnRpbAHOgghg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-SszgOoZ4Mgm2f0VxV_X_ww-1; Thu, 23 Apr 2020 10:57:58 -0400 X-MC-Unique: SszgOoZ4Mgm2f0VxV_X_ww-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F4631009441; Thu, 23 Apr 2020 14:57:57 +0000 (UTC) Received: from firesoul.localdomain (unknown [10.40.208.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id B86175D9CC; Thu, 23 Apr 2020 14:57:51 +0000 (UTC) Received: from [192.168.42.3] (localhost [IPv6:::1]) by firesoul.localdomain (Postfix) with ESMTP id DA435300020FB; Thu, 23 Apr 2020 16:57:50 +0200 (CEST) Subject: [PATCH net-next 2/2] dpaa2-eth: fix return codes used in ndo_setup_tc From: Jesper Dangaard Brouer Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, Ilias Apalodimas , =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , ruxandra.radulescu@nxp.com, ioana.ciornei@nxp.com, nipun.gupta@nxp.com, shawnguo@kernel.org Date: Thu, 23 Apr 2020 16:57:50 +0200 Message-ID: <158765387082.1613879.14971732890635443222.stgit@firesoul> In-Reply-To: <158765382862.1613879.11444486146802159959.stgit@firesoul> References: <158765382862.1613879.11444486146802159959.stgit@firesoul> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Drivers ndo_setup_tc call should return -EOPNOTSUPP, when it cannot support the qdisc type. Other return values will result in failing the qdisc setup. This lead to qdisc noop getting assigned, which will drop all TX packets on the interface. Fixes: ab1e6de2bd49 ("dpaa2-eth: Add mqprio support") Signed-off-by: Jesper Dangaard Brouer --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index 873b66ed3aee..a72f5a0d9e7c 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -2055,7 +2055,7 @@ static int dpaa2_eth_setup_tc(struct net_device *net_dev, int i; if (type != TC_SETUP_QDISC_MQPRIO) - return -EINVAL; + return -EOPNOTSUPP; mqprio->hw = TC_MQPRIO_HW_OFFLOAD_TCS; num_queues = dpaa2_eth_queue_count(priv); @@ -2067,7 +2067,7 @@ static int dpaa2_eth_setup_tc(struct net_device *net_dev, if (num_tc > dpaa2_eth_tc_count(priv)) { netdev_err(net_dev, "Max %d traffic classes supported\n", dpaa2_eth_tc_count(priv)); - return -EINVAL; + return -EOPNOTSUPP; } if (!num_tc) {