Re: unstable xdp tests. Was: [PATCH net-next v4 31/33] bpf: add xdp.frame_sz in bpf_prog_test_run_xdp().

Andrii Nakryiko
2020-05-18T19:19:28Z

On Mon, May 18, 2020 at 3:33 AM Jesper Dangaard Brouer
<brouer@redhat.com> wrote:
>
> On Mon, 18 May 2020 11:52:34 +0200
> Jesper Dangaard Brouer <brouer@redhat.com> wrote:
>
> > ... I'm getting unrelated compile errors for selftests/bpf in
> > bpf-next tree (HEAD 96586dd9268d2).
> >
> > The compile error, see below signature, happens in ./progs/bpf_iter_ipv6_route.c
> > (tools/testing/selftests/bpf/progs/bpf_iter_ipv6_route.c).
> >
> > Related to commit:
> > 7c128a6bbd4f ("tools/bpf: selftests: Add iterator programs for ipv6_route and netlink") (Author: Yonghong Song)
>
> After re-compiling the kernel in the same tree, this issue goes away.
>
> I guess this is related to:
> #include "vmlinux.h"
>

Yes, I ran into the same issue with libbpf CI tests for older kernel.
vmlinux.h for it simply doesn't contain definitions of bpf_iter__xxx
types. I think for selftests, it's better to have local copies of
those struct definitions, to make it compilable against older
vmlinux.h.

> --
> Best regards,
> Jesper Dangaard Brouer
> MSc.CS, Principal Kernel Engineer at Red Hat
> LinkedIn: http://www.linkedin.com/in/brouer
>