Re: [PATCH v2 net-next 4/4] sfc: document devlink flash support

[Jacob Keller <jacob.e.keller@intel.com>]

On 2/10/2025 6:50 AM, Edward Cree wrote:
> On 10/02/2025 13:51, Jiri Pirko wrote:
>> Mon, Feb 10, 2025 at 12:25:45PM +0100, edward.cree@amd.com wrote:
>>> Info versions
>>> =============
>>> @@ -18,6 +18,10 @@ The ``sfc`` driver reports the following versions
>>>    * - Name
>>>      - Type
>>>      - Description
>>> +   * - ``fw.bundle_id``
>>
>> Why "id"? It is the bundle version, isn't it. In that case just "bundle"
>> would be fine I guess...
> 
> bundle_id comes from DEVLINK_INFO_VERSION_GENERIC_FW_BUNDLE_ID in
>  include/net/devlink.h, which git blame tells me was added by Jacob
>  Keller in 2020 as a generalisation of a similar name in nfp.[1]
> Its use in sfc was added[2] by Alejandro Lucero in 2023 but seems to
>  have been left out of the documentation at that time.
> The present patch series is merely documenting the name that already
>  exists, not adding it.  Changing it might break existing scripts, and
>  in any case would affect more drivers than just sfc (it is used by
>  i40e, ice, and nfp).
> 
> CCing Jacob in case he has anything to add on why that name was chosen.
> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c90977a3c227
> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=14743ddd2495
> 

Yep. The versions were discussed extensively at [1] and I ultimately
settled on re-using fw.bundle_id as a generic name rather than having
nfp use bundle_id but everyone else use bundle [2]

[1]
https://lore.kernel.org/netdev/83a7a25e-50f0-862d-f535-92d64d86fd4f@intel.com/
[2]
https://lore.kernel.org/netdev/20200321081028.2763550-8-jeffrey.t.kirsher@intel.com/

I don't think we can really change this at this point given this is
effectively part of uABI.