Netdev List
 help / color / mirror / Atom feed
From: guodeqing <geffrey.guo@huawei.com>
To: <davem@davemloft.net>
Cc: <kuznet@ms2.inr.ac.ru>, <netdev@vger.kernel.org>,
	<dsa@cumulusnetworks.com>, <kuba@kernel.org>,
	<geffrey.guo@huawei.com>
Subject: [PATCH] net: Fix the arp error in some cases
Date: Wed, 17 Jun 2020 10:07:16 +0800	[thread overview]
Message-ID: <1592359636-107798-1-git-send-email-geffrey.guo@huawei.com> (raw)

ie.,
$ ifconfig eth0 6.6.6.6 netmask 255.255.255.0

$ ip rule add from 6.6.6.6 table 6666

$ ip route add 9.9.9.9 via 6.6.6.6

$ ping -I 6.6.6.6 9.9.9.9
PING 9.9.9.9 (9.9.9.9) from 6.6.6.6 : 56(84) bytes of data.

3 packets transmitted, 0 received, 100% packet loss, time 2079ms

$ arp
Address     HWtype  HWaddress           Flags Mask            Iface
6.6.6.6             (incomplete)                              eth0

The arp request address is error, this is because fib_table_lookup in 
fib_check_nh lookup the destnation 9.9.9.9 nexthop, the scope of 
the fib result is RT_SCOPE_LINK,the correct scope is RT_SCOPE_HOST.  
Here I add a check of whether this is RT_TABLE_MAIN to solve this problem. 

Fixes: 3bfd847203c6("net: Use passed in table for nexthop lookups")
Signed-off-by: guodeqing <geffrey.guo@huawei.com>
---
 net/ipv4/fib_semantics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index e53871e..1f75dc6 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib_semantics.c
@@ -1109,7 +1109,7 @@ static int fib_check_nh_v4_gw(struct net *net, struct fib_nh *nh, u32 table,
 		if (fl4.flowi4_scope < RT_SCOPE_LINK)
 			fl4.flowi4_scope = RT_SCOPE_LINK;
 
-		if (table)
+		if (table && table != RT_TABLE_MAIN)
 			tbl = fib_get_table(net, table);
 
 		if (tbl)
-- 
2.7.4


             reply	other threads:[~2020-06-17  2:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17  2:07 guodeqing [this message]
2020-06-17  3:10 ` [PATCH] net: Fix the arp error in some cases David Ahern
2020-06-17  3:38   ` 答复: " Guodeqing (A)
2020-06-17 12:44     ` David Ahern
  -- strict thread matches above, loose matches on Subject: below --
2020-06-16  1:00 guodeqing
2020-06-16  1:14 ` David Miller
2020-06-13  6:49 guodeqing
2020-06-13 14:31 ` David Ahern
2020-06-15 16:35 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1592359636-107798-1-git-send-email-geffrey.guo@huawei.com \
    --to=geffrey.guo@huawei.com \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=kuba@kernel.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox