From: Oliver Neukum <oneukum@suse.de>
To: "Bjørn Mork" <bjorn@mork.no>, netdev@vger.kernel.org
Cc: linux-usb@vger.kernel.org, wxcafe@wxcafe.net,
"Miguel Rodríguez Pérez" <miguel@det.uvigo.gal>
Subject: Re: [PATCH v5 net-next 2/5] net: cdc_ether: export usbnet_cdc_update_filter
Date: Tue, 21 Jul 2020 11:00:08 +0200 [thread overview]
Message-ID: <1595322008.29149.5.camel@suse.de> (raw)
In-Reply-To: <20200715184100.109349-3-bjorn@mork.no>
Am Mittwoch, den 15.07.2020, 20:40 +0200 schrieb Bjørn Mork:
>
> @@ -90,6 +90,7 @@ static void usbnet_cdc_update_filter(struct usbnet *dev)
> USB_CTRL_SET_TIMEOUT
> );
> }
> +EXPORT_SYMBOL_GPL(usbnet_cdc_update_filter);
Hi,
this function is pretty primitive. In fact it more or less
is a straight take from the spec. Can this justify the _GPL
version?
Regards
Oliver
next prev parent reply other threads:[~2020-07-21 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 18:40 [PATCH v5 net-next 0/5] usbnet: multicast filter support for cdc ncm devices Bjørn Mork
2020-07-15 18:40 ` [PATCH v5 net-next 1/5] net: cdc_ether: use dev->intf to get interface information Bjørn Mork
2020-07-15 18:40 ` [PATCH v5 net-next 2/5] net: cdc_ether: export usbnet_cdc_update_filter Bjørn Mork
2020-07-21 9:00 ` Oliver Neukum [this message]
2020-07-24 14:18 ` Bjørn Mork
2020-07-27 13:03 ` Oliver Neukum
2020-07-15 18:40 ` [PATCH v5 net-next 3/5] net: usbnet: export usbnet_set_rx_mode() Bjørn Mork
2020-07-15 18:40 ` [PATCH v5 net-next 4/5] net: cdc_ncm: add .ndo_set_rx_mode to cdc_ncm_netdev_ops Bjørn Mork
2020-07-15 18:41 ` [PATCH v5 net-next 5/5] net: cdc_ncm: hook into set_rx_mode to admit multicast traffic Bjørn Mork
2020-07-17 19:43 ` [PATCH v5 net-next 0/5] usbnet: multicast filter support for cdc ncm devices David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595322008.29149.5.camel@suse.de \
--to=oneukum@suse.de \
--cc=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=miguel@det.uvigo.gal \
--cc=netdev@vger.kernel.org \
--cc=wxcafe@wxcafe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).