From: Ilia Lin <ilial@codeaurora.org>
To: davem@davemloft.net, kuba@kernel.org, jiri@mellanox.com,
edumazet@google.com, ap420073@gmail.com,
xiyou.wangcong@gmail.com, maximmi@mellanox.com,
ilia.lin@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] net: dev: Add API to check net_dev readiness
Date: Sun, 26 Jul 2020 22:37:54 +0300 [thread overview]
Message-ID: <1595792274-28580-1-git-send-email-ilial@codeaurora.org> (raw)
From: Ilia Lin <ilia.lin@kernel.org>
Add an API that returns true, if the net_dev_init was already called,
and the driver was initialized.
Some early drivers, that are initialized during the subsys_initcall
may try accessing the net_dev or NAPI APIs before the net_dev_init,
and will encounter a kernel bug. This API provides a way to handle
this and manage by deferring or by other way.
Signed-off-by: Ilia Lin <ilia.lin@kernel.org>
---
include/linux/netdevice.h | 2 ++
net/core/dev.c | 17 +++++++++++++++++
2 files changed, 19 insertions(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 98d290c..d17d364 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2600,6 +2600,8 @@ enum netdev_cmd {
};
const char *netdev_cmd_to_name(enum netdev_cmd cmd);
+bool is_net_dev_initialized(void);
+
int register_netdevice_notifier(struct notifier_block *nb);
int unregister_netdevice_notifier(struct notifier_block *nb);
int register_netdevice_notifier_net(struct net *net, struct notifier_block *nb);
diff --git a/net/core/dev.c b/net/core/dev.c
index 316349f..1b50488 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1793,6 +1793,23 @@ static void call_netdevice_unregister_net_notifiers(struct notifier_block *nb,
static int dev_boot_phase = 1;
/**
+ * is_net_dev_initialized - check, whether the net_dev was
+ * initialized
+ *
+ * Returns true, if the net_dev_init was already called, and
+ * the driver is initialized.
+ *
+ * This is useful for early drivers trying to call net_dev and
+ * NAPI APIs
+ */
+
+bool is_net_dev_initialized(void)
+{
+ return !(bool)dev_boot_phase;
+}
+EXPORT_SYMBOL(is_net_dev_initialized);
+
+/**
* register_netdevice_notifier - register a network notifier block
* @nb: notifier
*
next reply other threads:[~2020-07-26 19:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 19:37 Ilia Lin [this message]
2020-07-26 19:45 ` [PATCH] net: dev: Add API to check net_dev readiness Andrew Lunn
2020-07-27 17:32 ` David Miller
2020-08-04 17:47 ` Ilia Lin
2020-08-04 19:24 ` Andrew Lunn
2020-08-05 10:31 ` Ilia Lin
2020-08-05 13:14 ` Andrew Lunn
2020-08-04 18:42 ` Ilia Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595792274-28580-1-git-send-email-ilial@codeaurora.org \
--to=ilial@codeaurora.org \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ilia.lin@kernel.org \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).