From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
bpf <bpf@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Networking <netdev@vger.kernel.org>,
Vaidyanathan Srinivasan <svaidy@linux.ibm.com>
Subject: Re: [PATCH] libbpf: Remove arch-specific include path in Makefile
Date: Thu, 03 Sep 2020 11:16:12 +0530 [thread overview]
Message-ID: <1599111859.vtxbe8ojub.naveen@linux.ibm.com> (raw)
In-Reply-To: <fc8b0c65-b74a-d924-4189-ff6359d1ebdc@iogearbox.net>
Daniel Borkmann wrote:
> On 9/2/20 10:58 PM, Andrii Nakryiko wrote:
>> On Wed, Sep 2, 2020 at 1:43 AM Naveen N. Rao
>> <naveen.n.rao@linux.vnet.ibm.com> wrote:
>>>
>>> Ubuntu mainline builds for ppc64le are failing with the below error (*):
>>> CALL /home/kernel/COD/linux/scripts/atomic/check-atomics.sh
>>> DESCEND bpf/resolve_btfids
>>>
>>> Auto-detecting system features:
>>> ... libelf: [ [32mon[m ]
>>> ... zlib: [ [32mon[m ]
>>> ... bpf: [ [31mOFF[m ]
>>>
>>> BPF API too old
>>> make[6]: *** [Makefile:295: bpfdep] Error 1
>>> make[5]: *** [Makefile:54: /home/kernel/COD/linux/debian/build/build-generic/tools/bpf/resolve_btfids//libbpf.a] Error 2
>>> make[4]: *** [Makefile:71: bpf/resolve_btfids] Error 2
>>> make[3]: *** [/home/kernel/COD/linux/Makefile:1890: tools/bpf/resolve_btfids] Error 2
>>> make[2]: *** [/home/kernel/COD/linux/Makefile:335: __build_one_by_one] Error 2
>>> make[2]: Leaving directory '/home/kernel/COD/linux/debian/build/build-generic'
>>> make[1]: *** [Makefile:185: __sub-make] Error 2
>>> make[1]: Leaving directory '/home/kernel/COD/linux'
>>>
>>> resolve_btfids needs to be build as a host binary and it needs libbpf.
>>> However, libbpf Makefile hardcodes an include path utilizing $(ARCH).
>>> This results in mixing of cross-architecture headers resulting in a
>>> build failure.
>>>
>>> The specific header include path doesn't seem necessary for a libbpf
>>> build. Hence, remove the same.
>>>
>>> (*) https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.9-rc3/ppc64el/log
>>>
>>> Reported-by: Vaidyanathan Srinivasan <svaidy@linux.ibm.com>
>>> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
>>> ---
>>
>> This seems to still build fine for me, so I seems fine. Not sure why
>> that $(ARCH)/include/uapi path is there.
>>
>> Acked-by: Andrii Nakryiko <andriin@fb.com>
>
> Same here, builds fine from my side too. Looks like this was from the very early days,
> added in commit 1b76c13e4b36 ("bpf tools: Introduce 'bpf' library and add bpf feature
> check"). Applied, thanks!
Thanks!
Daniel, I see that this has been applied to bpf-next. Can you please
consider sending this in for v5.9-rc series so as to resolve the build
failures?
- Naveen
next prev parent reply other threads:[~2020-09-03 5:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 8:42 [PATCH] libbpf: Remove arch-specific include path in Makefile Naveen N. Rao
2020-09-02 20:58 ` Andrii Nakryiko
2020-09-02 21:51 ` Daniel Borkmann
2020-09-03 5:46 ` Naveen N. Rao [this message]
2020-09-03 13:51 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599111859.vtxbe8ojub.naveen@linux.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=svaidy@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).