From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 320E317CF for ; Fri, 2 Feb 2024 12:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706877685; cv=fail; b=sRy5Il7neu7YNOvqHN+LECOpkmj+hMoQRcK23W5VYX0Aw3QbQCJqwcy8p9rL9U5rnVUa4fEp2EFnXNRUTBxPUfwRPuU1qlXn5ffzReVQZpeHXORfM6ZU2zgrqraIkkLHbGZw21kzoly81UoZUKjCt7j/2rlcg0JVrpPNB22BcH8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706877685; c=relaxed/simple; bh=EnZBeD4Hpg4O4YTpRUE4l119FfFUTkvxUvinaHhFpfo=; h=Message-ID:Date:Subject:From:To:CC:References:In-Reply-To: Content-Type:MIME-Version; b=H/v4rPe0G24yXyt/miVwWzslgXqFzPtJOwvZFjxUGTQAMP5yuDNJjxgsxrp/s2DLDZgYeFz6S84qf+vkTMEHPLebOaY08s/GzekjKZaWvXgBXq8eF8dead5AkjHDN26bHQw9sZoeBV2z6630vOXEogv7BhHoPi4jbYUnx5gP2j4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LByo3m69; arc=fail smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LByo3m69" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706877683; x=1738413683; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=EnZBeD4Hpg4O4YTpRUE4l119FfFUTkvxUvinaHhFpfo=; b=LByo3m69wdx5gPS26fGOuDde5Wa35pxIogoRA5gJfDS6eLVAv0uvBXnO Hay2HMY0l6T4s5dKTcFKZyRm83bxPn0eQi5kvTh9HQS2u1z7peeP1DJ7g q7edouT9o1svLQpoV/xWlsmEEJndXYWkZyjFdXNuy4SkuEinxX+2uC6hQ b/7tsNYIhr5ejujXnN82wnvKsTHFEOxi4kN3lEOP0iCiUSz6AJMoQwwHi fBN5FfNwc05qeXlFy0YyVBfMA3/aXznzHVQw+vgXiTnjdl3ErCm69nqCz lc9FA9zCIroyatVRbCyRXFFdMXCbEPtxb9VBqXCEe5oM/u6o3DYDreO74 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="4051325" X-IronPort-AV: E=Sophos;i="6.05,238,1701158400"; d="scan'208";a="4051325" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2024 04:41:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,238,1701158400"; d="scan'208";a="77914" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Feb 2024 04:41:23 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 04:41:21 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 2 Feb 2024 04:41:21 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 2 Feb 2024 04:41:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wnf84XGDc9TW5AJrx6/xWL4D7TVgZmTkP78PM6Yqzd8PmUwbm5qyvHvCKGJP6RJCx7ivR9GL2GxEBPOCBEzWCXOYqPIExEmq1TCxu+cj0XUPVep8P0pms7z73pFeowKBcLS/EJrccSIqceeIzACIoq6SQuRB7vi0FzBKhhlJe3oKhd74OdXmrP8M5dFZo+EqNLdbXsJbo8A5bKX5rFdiFkOxru9AULY/RmRf4H1v2x/CeNEO5hhf+EoGZjYExng/d5z63UcSE3tG0Xco5XOpUDYQ9iB47qFuCA2vN3ZZpW/ud1+6UndqTphBkzNTosPeSKTW1YdC23poBRDxTZzdcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bEqMi/th0dOUMlR0sK255BoK9QdVZsIxL7Ce1T3ND+Q=; b=FF+3xTI1Ou/9GywEHnuUSN+6IpeyclJGZd8Xl+H5G+DG1GiYiME8xvEAkS/RhDJyknWkQA+ti1cn7D1Qt6utjdIdg2JRoWU6ZE7waJBM+fVanEbwy+HXFQbbKVGpmd+lrqYyFt3DXJfhkumcnrRkB6uKNXiljV+bsfr2WLrjakXSRZS8vpC1kQoLBp14tQAvMC9UVph78sabdkcTBQy9sK6oiHJ4NDosqb+PA4ghC99QWoJmwGcryrFf+nujscw93kZUmpuNNHryqQdlU8llvABR0rmxxbGQuhFu7OdnkfIWj2D3umYcd3mqaLKxqrEvZHyXFycBnibWn6gjGd8orA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20) by LV8PR11MB8533.namprd11.prod.outlook.com (2603:10b6:408:1e5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.30; Fri, 2 Feb 2024 12:41:18 +0000 Received: from DS0PR11MB8718.namprd11.prod.outlook.com ([fe80::8760:b5ec:92af:7769]) by DS0PR11MB8718.namprd11.prod.outlook.com ([fe80::8760:b5ec:92af:7769%6]) with mapi id 15.20.7249.027; Fri, 2 Feb 2024 12:41:18 +0000 Message-ID: <15af160b-54b1-4f27-ad72-01fc27601f69@intel.com> Date: Fri, 2 Feb 2024 13:40:18 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH net] ice: fix unaligned access in ice_create_lag_recipe Content-Language: en-US From: Alexander Lobakin To: Michal Schmidt CC: Jiri Pirko , Daniel Machon , , Jesse Brandeburg , Tony Nguyen , "Dave Ertman" , References: <20240131115823.541317-1-mschmidt@redhat.com> <8c35a3f0-26a2-4bdd-afe1-dcd11fb67405@intel.com> <48ce5a45-4d95-4d12-83ef-ee7d15bb9773@redhat.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: VE1PR08CA0032.eurprd08.prod.outlook.com (2603:10a6:803:104::45) To DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB8718:EE_|LV8PR11MB8533:EE_ X-MS-Office365-Filtering-Correlation-Id: 6da289a9-2921-4ab2-0ae9-08dc23ec40b2 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: avBNqqHm+8ziZD68JUsu6QijbLVXY+vlAcxE3PB/FG9McWNJ/tF0NnKcGXwwEsxbtzMlwN45V1AWDhwTPg8LetwIgOhClHEywAH2iELygT7w7K6tkNlJh9Umk08fGBp08MjF4C57E71ZDE0Xv0PP0rL0311eW4MbZLkjY8iOv61jIRIGKet6UeghvM9AOoGE6d0SPsC7CvJRCXVJ5PA9PorOcUjscn+y9pXrMO7RsAd2+lF4XIeXKhaxMvSJvpeiUM2gHITqDZJbN1h1hEU3waANzBNVOD45uMbbe1FW+gajeEzJrFZoDjt5Dh4/K/dXWr4as+UCcBZcfJKk9fwGZ92lLGe2jTJ6HrL8ae9PE/nI2Mrs97NfNz6UMfAPnrJqjMOc/NMwEqAv5xmTgVah6aJ20n1WeeDldzVK/2kmi5tLPygPZJGngUGDpKVzxpshDBkMR+yoT6uzyLcbmcqIADqpfT1YRvURe1Jg7NZ0guZK+GjUVPyXqRXRBpLWJw2AFj5fUsahoX85stplZN7gaR0YYRrBy3t+OsOsg42b166F44npzvKuQz1mbaV4SubZlwpSoZXBeA62aHkGmtmmpcvo5uj/ZnPODHZbF2WsgvUGUQf5mhMsz/mTTkyNXeeqLBOjYR/Kot1agAd/Adx2IQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB8718.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(396003)(376002)(366004)(136003)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(5660300002)(478600001)(966005)(6486002)(86362001)(6506007)(31696002)(6512007)(53546011)(8676002)(8936002)(66556008)(54906003)(66946007)(66476007)(6916009)(316002)(4326008)(36756003)(38100700002)(2616005)(41300700001)(26005)(82960400001)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFJwYXZTWmU0UjZneWI5dWJVcFYxSUxRNVFLeTJKMk5oSmlOUTV0eFhOcUJm?= =?utf-8?B?KzdjTGdaTzZPRFBvUjZEWGl4VWdwS1BNQW85WWJVbFpsbVp0aWZNYVVTZTNO?= =?utf-8?B?bjQ4dmN2TlZBSndtWlRndGZPTTBGSnBwSXpCRFhpYmhCSk1BdklHKzMyUHBP?= =?utf-8?B?NjlTSTdSdzNoTFpSSHg3blJ3VVFpeVV0aCtnYWdWYXhOamU2dVBkMERpNTNm?= =?utf-8?B?VXZ3czBkV2R5OFJJOWJHRFVxNVdWSlFudmRSQTRVWXNoUUdKRUhsWlpHNngz?= =?utf-8?B?YTltbzllV0pQUUVzOGdVekZGZXc5aE9xOXJPbWtFTVZMekdvdmhmaU9oN2VH?= =?utf-8?B?bU1rYU5MZXBSbWpYdzJNWUI5MmN0QzE3MVFxZC9DL29LekdyenpNVjQ1VElu?= =?utf-8?B?cWtkR3ZNNEpGdlpyd3Z1cjlxMEFMdTdYdXpkVzJYbWh1RCs1akxJUFI3R2VG?= =?utf-8?B?T29rYWRmWDF4ZTVGcjJlcWhaOHgvRnppNkU1SmF0VTFyMUY1ZW1CQVh1aG1P?= =?utf-8?B?QTdVd2NEUFhId21GZ3UreGJQVVBTSSsyNzFKakpINFlJdnNpOVlpcUNyZTA4?= =?utf-8?B?cjdWRUd4eHpSNG9PUmx5aVg4TWpBUEd5c0g0TTVoNFQ4bEtNUmtDN21tTi9p?= =?utf-8?B?L0tLR1kxYUVEWGRkeWZqakp3V3dpK1hJLy9lVWZleEljVXpXTlNTa0hjUUFC?= =?utf-8?B?NGsranVvMVpXeUJTQjJseElwNHIwZXkrNGVFWUM5N0hDR011emJTZXpZR3Fz?= =?utf-8?B?RjFGR0N1NHZnUTNEaWx2VGNRcWZqNGYzZDZ6akZXY2F1YmFTeTRSYlptT2py?= =?utf-8?B?US9yV1JBdHRSSXNXK0puMVZkMHFON3h1dVVpV1FDSklHVFlYNFlyYUNuVlVY?= =?utf-8?B?anRoYmVSay9NVTExYmVzSkRDcURhVk5SWTlGaFh4RTQwak91QU5IaUhLTk8y?= =?utf-8?B?QUxYSFRPT0hTRWQwMWg3elZUakhDQUxNVThRKzJvcXZFNU9Ranc3RHhpWDM3?= =?utf-8?B?SUdtdUJCRkF2WnFNWFN1ZHZhQTB4dC9XS0UwcjB5M1dETlhob3VINGdLRXQ2?= =?utf-8?B?dmZROFp3aHVqdVphVTIwaGlPNngvU1pvRUhaRzc1eWtQVnQ4NmFYNWV0bkg3?= =?utf-8?B?amRpdWhKNzA3SVRvTDhScmwwTm5TMm1vamgwTTBpVitFRCs5eWxTNGswb0VI?= =?utf-8?B?UHB4cGhJOHY4cmxidkdRRVMyb1BpWGZ2OVU2cy9WUXZpa1pueWxNZkRBNmgr?= =?utf-8?B?RU05NEh6bVVya2VZZGFjRDhSTE5wRW1sOG1ROW81bHAxT2tBdWVmWXF0ZXY0?= =?utf-8?B?MEV0SWJEYVJpWGRHRmd1T2s4eEdlVGlvMnBmRDdaTnhvajkrK1hiZ29Ca0k2?= =?utf-8?B?WUtMT2lHUWxxN090L01GbDJlUllPUG44T1ViN1NRbWJ1cG43c2pNQS80OWgx?= =?utf-8?B?N0ZoelM5ZncyaWZMM2szS0RwcWJMeVdlMk1veHYrQTNmOWRJb2pSTXhpV0tP?= =?utf-8?B?M0lsTDdIY2ErNjRHb3RGRHc3YjBiZmxGdkV0THdnT1NDWGhKRmxIdjgvWTB5?= =?utf-8?B?cUFRa0ZBYjIxaEU0dXFHeEZVK0dIUXlnVGNLWXNEcDRGMzlTRWdsTkV5V082?= =?utf-8?B?NzNtVzd6ZmdsN3VQd3VNZE51eUY1eE9OckQyNlJqeVJWSHFVVWJRbVpaUHNX?= =?utf-8?B?UCs0WHhzNnJMRWgwbkJNc3lobmFDVWJLdkt2WG9DSnAyVlJZRXAvMHExMEpm?= =?utf-8?B?Si9SZzRTdGNjSTZFQ1RlK2E1TDV4bGNNZ09XM2lEMEp4dUU5S1NybjlERm1U?= =?utf-8?B?RTJIMlBBVDNaenF3VEo2SUVQbFQyM2lnY2F4Wm1SNU03OGcraDVOTDBuWWI5?= =?utf-8?B?RzZHZFdsSVBHRTdYbENSU0ZIRjVIcHh0RVhXb3dVNStRSDdFd1JZZXhXT3Ey?= =?utf-8?B?bjVrd3dkTTRhcmpaTEtuMllxeTVPTEVDVW5lWnU1eVJHak5lY3p1TkdHK3Ba?= =?utf-8?B?Ymg4RkR6ckVmSzRFZTBjVHlJZHVmUGZPdGVwa3RiT29QTURWVTBmTFl5T3pV?= =?utf-8?B?cnR4UmppcEROdjc2dmxPSkJwZGtIZVRMUUg0MkY4SktTb093NFliejRhUis4?= =?utf-8?B?VlZFZHU5Vnc3NEwxTTRoWXBPdW1UTXJKK2RIM2hLQkhzUnB3RTIySzJZU3B5?= =?utf-8?B?c1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6da289a9-2921-4ab2-0ae9-08dc23ec40b2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 12:41:18.5276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: grQgY5Dvgw2NEsH3FUptub1xAbVeu7AKkDd1KAGXwm9zDfGEkjWWq0rMcgTQ8O1Ht0gTIKvodeAGL4O3mCMyFB8UrSvYouN/L3bhLYkf64w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8533 X-OriginatorOrg: intel.com From: Alexander Lobakin Date: Fri, 2 Feb 2024 13:39:28 +0100 > From: Michal Schmidt > Date: Thu, 1 Feb 2024 19:40:17 +0100 > >> On 1/31/24 17:59, Alexander Lobakin wrote: >>> From: Jiri Pirko >>> Date: Wed, 31 Jan 2024 13:17:44 +0100 >>> >>>> Wed, Jan 31, 2024 at 12:58:23PM CET, mschmidt@redhat.com wrote: >>>>> diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c >>>>> b/drivers/net/ethernet/intel/ice/ice_lag.c >>>>> index 2a25323105e5..d4848f6fe919 100644 >>>>> --- a/drivers/net/ethernet/intel/ice/ice_lag.c >>>>> +++ b/drivers/net/ethernet/intel/ice/ice_lag.c >>>>> @@ -1829,9 +1829,7 @@ static int ice_create_lag_recipe(struct ice_hw >>>>> *hw, u16 *rid, >>>>>     new_rcp->content.act_ctrl_fwd_priority = prio; >>>>>     new_rcp->content.rid = *rid | ICE_AQ_RECIPE_ID_IS_ROOT; >>>>>     new_rcp->recipe_indx = *rid; >>>>> -    bitmap_zero((unsigned long *)new_rcp->recipe_bitmap, >>>>> -            ICE_MAX_NUM_RECIPES); >>>>> -    set_bit(*rid, (unsigned long *)new_rcp->recipe_bitmap); >>>>> +    put_unaligned_le64(BIT_ULL(*rid), new_rcp->recipe_bitmap); >>>> >>>> Looks like there might be another incorrect bitmap usage for this in >>>> ice_add_sw_recipe(). Care to fix it there as well? >>> >>> Those are already fixed in one switchdev series and will be sent to IWL >>> soon. >>> I believe this patch would also make no sense after it's sent. >> >> Hi Alexander, >> When will the series be sent? >> The bug causes a kernel panic. Will the series target net.git? > > The global fix is here: [0] > It's targeting net-next. > > I don't know what the best way here would be. Target net instead or pick > your fix to net and then fix it properly in net-next? Sorry, forgot to paste the link :clownface: [0] https://lore.kernel.org/intel-wired-lan/20240130025146.30265-2-steven.zou@intel.com Thanks, Olek