From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 3/3] net/ipv6: Add support for onlink flag Date: Wed, 24 Jan 2018 15:08:39 -0700 Message-ID: <15b326c5-a3e5-14a2-2034-072f2d2794fb@gmail.com> References: <20180124030004.4016-1-dsahern@gmail.com> <20180124030004.4016-4-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: yoshfuji@linux-ipv6.org, idosch@mellanox.com, roopa@cumulusnetworks.com To: netdev@vger.kernel.org, David Miller Return-path: Received: from mail-pg0-f41.google.com ([74.125.83.41]:42754 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932902AbeAXWIm (ORCPT ); Wed, 24 Jan 2018 17:08:42 -0500 Received: by mail-pg0-f41.google.com with SMTP id q67so3680291pga.9 for ; Wed, 24 Jan 2018 14:08:42 -0800 (PST) In-Reply-To: <20180124030004.4016-4-dsahern@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/23/18 8:00 PM, David Ahern wrote: > + tbid = l3mdev_fib_table(dev) ? : RT_TABLE_MAIN; > + if (cfg->fc_table && cfg->fc_table != tbid) { > + NL_SET_ERR_MSG(extack, > + "Table id mismatch between given table and device"); > + return -EINVAL; > + } > + > + cfg->fc_table = tbid; > + > + return 0; This table check is too restrictive for some PBR cases. Dave: please drop this set; I'll repost.