From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD956C43334 for ; Fri, 10 Jun 2022 22:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347056AbiFJWDE (ORCPT ); Fri, 10 Jun 2022 18:03:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344309AbiFJWDC (ORCPT ); Fri, 10 Jun 2022 18:03:02 -0400 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28DFC274D77; Fri, 10 Jun 2022 15:03:01 -0700 (PDT) Received: from sslproxy01.your-server.de ([78.46.139.224]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1nzmiY-0001ia-W2; Sat, 11 Jun 2022 00:02:59 +0200 Received: from [85.1.206.226] (helo=linux.home) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzmiY-0001CB-ML; Sat, 11 Jun 2022 00:02:58 +0200 Subject: Re: [PATCH bpf-next v2 0/7] Add bpf_link based TC-BPF API To: Alexei Starovoitov , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= Cc: Kumar Kartikeya Dwivedi , Joanne Koong , bpf , Alexei Starovoitov , Andrii Nakryiko , Jamal Hadi Salim , Vlad Buslov , Cong Wang , Jesper Dangaard Brouer , netdev References: <20210604063116.234316-1-memxor@gmail.com> <20220610125830.2tx6syagl2rphl35@apollo.legion> <20220610193418.4kqpu7crwfb5efzy@apollo.legion> <87h74s2s19.fsf@toke.dk> <2f98188b-813b-e226-4962-5c2848998af2@iogearbox.net> <87bkv02qva.fsf@toke.dk> From: Daniel Borkmann Message-ID: <15bdc24c-fe85-479a-83fe-921da04cb6b1@iogearbox.net> Date: Sat, 11 Jun 2022 00:02:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.6/26568/Fri Jun 10 10:06:23 2022) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6/10/22 11:52 PM, Alexei Starovoitov wrote: > On Fri, Jun 10, 2022 at 1:41 PM Toke Høiland-Jørgensen wrote: >> >>>> Except we'd want to also support multiple programs on different >>>> priorities? I don't think requiring a libxdp-like dispatcher to achieve >>>> this is a good idea if we can just have it be part of the API from the >>>> get-go... >>> >>> Yes, it will be multi-prog to avoid a situation where dispatcher is needed. >> >> Awesome! :) > > Let's keep it simple to start. > Priorities or anything fancy can be added later if really necessary. > Otherwise, I'm afraid, we will go into endless bikeshedding > or the best priority scheme. > > A link list of bpf progs like cls_bpf with the same semantics as > cls_bpf_classify. > With prog->exts_integrated always true and no classid, since this > concept doesn't apply. Yes, semantics must be that TC_ACT_UNSPEC continues in the list and everything else as return code would terminate the evaluation.