From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Laight Subject: RE: [PATCH v2 1/5] netlink: remove NLA_NESTED_COMPAT Date: Thu, 20 Sep 2018 14:54:59 +0000 Message-ID: <15cc8087b97d4b8693fad397b27f4d10@AcuMS.aculab.com> References: <20180919194905.16462-1-johannes@sipsolutions.net> <20180919194905.16462-2-johannes@sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Cc: David Ahern , Johannes Berg To: 'Johannes Berg' , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" Return-path: Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:57272 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732640AbeITUm5 (ORCPT ); Thu, 20 Sep 2018 16:42:57 -0400 In-Reply-To: <20180919194905.16462-2-johannes@sipsolutions.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: From: Johannes Berg > Sent: 19 September 2018 20:49 > This isn't used anywhere, so we might as well get rid of it. > > Reviewed-by: David Ahern > Signed-off-by: Johannes Berg > --- > include/net/netlink.h | 2 -- > lib/nlattr.c | 11 ----------- > 2 files changed, 13 deletions(-) > > diff --git a/include/net/netlink.h b/include/net/netlink.h > index 318b1ded3833..b680fe365e91 100644 > --- a/include/net/netlink.h > +++ b/include/net/netlink.h > @@ -172,7 +172,6 @@ enum { > NLA_FLAG, > NLA_MSECS, > NLA_NESTED, > - NLA_NESTED_COMPAT, > NLA_NUL_STRING, > NLA_BINARY, > NLA_S8, ... Is it safe to remove an item from this emun ? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)