From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BC94C433DF for ; Mon, 12 Oct 2020 08:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F16EC206F4 for ; Mon, 12 Oct 2020 08:11:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=hartkopp.net header.i=@hartkopp.net header.b="TOxaEwea" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727396AbgJLILP (ORCPT ); Mon, 12 Oct 2020 04:11:15 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.165]:22388 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726680AbgJLILO (ORCPT ); Mon, 12 Oct 2020 04:11:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1602490272; s=strato-dkim-0002; d=hartkopp.net; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=Ce5zlBgUbgMoI21spf1Z+7npuKulzdfpTbSuT1EkH2w=; b=TOxaEweaVFkGArnUhLtNypOvTkw60++WBFBRiD0BWxMoiiBmf8KJxq9X7HDfeatMcO f0+ggkZxM8LPg5KiqdsYtomEMansnxgKRV4f8tev1zXeVn7RG8ZMGdk7pY6ovLljqvzq RSzIf8fWahECnbgfU62QSoGPpJEt6FcpguxhRYrUCGNUQZ4kVGfgb2WYA/Lho7QtXnek PyX6cnHu/VOPg/WiIvy/n55oujTiwJF4vhpJ0nS/tCBnziSCmrA8C55rdQ66OPmX8+6M z5+i+is5aCkPh0VDBAXMVp59Z1jFxqu8ITvBJgueWX9HLXXmCe7RSBw+qCcM/T7FtlmI QQtg== X-RZG-AUTH: ":P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrDxb8mjG14FZxedJy6qgO1o3TMaFqTGVxiOM9spw==" X-RZG-CLASS-ID: mo00 Received: from [192.168.10.137] by smtp.strato.de (RZmta 47.2.1 DYNA|AUTH) with ESMTPSA id D0b41cw9C8B4OSj (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 12 Oct 2020 10:11:04 +0200 (CEST) Subject: Re: [PATCH net-next v3 1/2] can-isotp: implement cleanups / improvements from review To: Marc Kleine-Budde , kuba@kernel.org, netdev@vger.kernel.org Cc: davem@davemloft.net, linux-can@vger.kernel.org References: <20201012074354.25839-1-socketcan@hartkopp.net> <7e64959a-9f73-0f0d-bdd9-b12dc65321cb@pengutronix.de> From: Oliver Hartkopp Message-ID: <15d1b847-d717-7f85-af3f-aaaeef28bd6d@hartkopp.net> Date: Mon, 12 Oct 2020 10:11:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <7e64959a-9f73-0f0d-bdd9-b12dc65321cb@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12.10.20 10:05, Marc Kleine-Budde wrote: > On 10/12/20 9:43 AM, Oliver Hartkopp wrote: >> As pointed out by Jakub Kicinski here: >> http://lore.kernel.org/r/20201009175751.5c54097f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com >> this patch addresses the remarked issues: >> >> - remove empty line in comment >> - remove default=y for CAN_ISOTP in Kconfig >> - make use of pr_notice_once() >> - use GFP_ATOMIC instead of gfp_any() in soft hrtimer context >> >> The version strings in the CAN subsystem are removed by a separate patch. >> >> Signed-off-by: Oliver Hartkopp >> --- > > Added both to linux-can-next. The patches were intended for 'net-next' as the merge window will open *very* soon. I'm not sure if there would be another pull from linux-can-next until then, therefore I would suggest that Jakub takes the patches himself. Thanks, Oliver