From: Boris Pismenny <borisp@mellanox.com>
To: Vakul Garg <vakul.garg@nxp.com>, netdev@vger.kernel.org
Cc: aviadye@mellanox.com, davejwatson@fb.com, davem@davemloft.net
Subject: Re: [net-next v3 1/5] net/tls: Do not enable zero-copy prematurely
Date: Thu, 19 Jul 2018 06:28:05 -0400 [thread overview]
Message-ID: <1601b472-319e-f1c8-6a71-be883aa18bd2@mellanox.com> (raw)
In-Reply-To: <20180719111643.12787-2-vakul.garg@nxp.com>
Hi Vakul,
On 7/19/2018 7:16 AM, Vakul Garg wrote:
> Zero-copy mode was left enabled even when zerocopy_from_iter() failed.
> Set the zero-copy mode only when zerocopy_from_iter() succeeds. This
> leads to removal of argument 'zc' of function decrypt_skb_update().
> Function decrypt_skb_update() does not need to check whether
> ctx->decrypted is set since it is never called if ctx->decrypted is
> true.
>
This patch breaks our tls_device code for the following 2 reasons:
1. We need to disable zerocopy if the device decrypted the record,
because decrypted data has to be copied to user buffers.
2. ctx->decrypted must be checked in decrypt_skb_update, because it
might change after calling tls_device_decrypted.
next prev parent reply other threads:[~2018-07-19 11:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 11:16 [net-next v3 0/5] net/tls: Minor code cleanup patches Vakul Garg
2018-07-19 11:16 ` [net-next v3 1/5] net/tls: Do not enable zero-copy prematurely Vakul Garg
2018-07-19 10:28 ` Boris Pismenny [this message]
2018-07-19 10:32 ` Vakul Garg
2018-07-19 11:16 ` [net-next v3 2/5] net/tls: Use socket data_ready callback on record availability Vakul Garg
2018-07-19 11:16 ` [net-next v3 3/5] net/tls: Remove redundant variable assignments and wakeup Vakul Garg
2018-07-19 11:16 ` [net-next v3 4/5] net/tls: Remove redundant array allocation Vakul Garg
2018-07-19 11:16 ` [net-next v3 5/5] net/tls: Rework error checking after decrypt_skb_update() Vakul Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1601b472-319e-f1c8-6a71-be883aa18bd2@mellanox.com \
--to=borisp@mellanox.com \
--cc=aviadye@mellanox.com \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox