From: Alexander Duyck <alexander.duyck@gmail.com>
To: bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, kafai@fb.com,
john.fastabend@gmail.com, kernel-team@fb.com,
netdev@vger.kernel.org, edumazet@google.com, brakmo@fb.com,
alexanderduyck@fb.com
Subject: [bpf-next PATCH 4/4] selftests/bpf: Migrate tcpbpf_user.c to use BPF skeleton
Date: Tue, 27 Oct 2020 18:47:28 -0700 [thread overview]
Message-ID: <160384964803.698509.11020605670605638967.stgit@localhost.localdomain> (raw)
In-Reply-To: <160384954046.698509.132709669068189999.stgit@localhost.localdomain>
From: Alexander Duyck <alexanderduyck@fb.com>
Update tcpbpf_user.c to make use of the BPF skeleton. Doing this we can
simplify test_tcpbpf_user and reduce the overhead involved in setting up
the test.
Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>
---
.../testing/selftests/bpf/prog_tests/tcpbpf_user.c | 48 +++++++++-----------
1 file changed, 21 insertions(+), 27 deletions(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/tcpbpf_user.c b/tools/testing/selftests/bpf/prog_tests/tcpbpf_user.c
index 4e1190894e1e..7e92c37976ac 100644
--- a/tools/testing/selftests/bpf/prog_tests/tcpbpf_user.c
+++ b/tools/testing/selftests/bpf/prog_tests/tcpbpf_user.c
@@ -5,6 +5,7 @@
#include "test_tcpbpf.h"
#include "cgroup_helpers.h"
+#include "test_tcpbpf_kern.skel.h"
#define LO_ADDR6 "::1"
#define CG_NAME "/tcpbpf-user-test"
@@ -162,39 +163,32 @@ static void run_test(int map_fd, int sock_map_fd)
void test_tcpbpf_user(void)
{
- const char *file = "test_tcpbpf_kern.o";
- int prog_fd, map_fd, sock_map_fd;
- struct bpf_object *obj;
+ struct test_tcpbpf_kern *skel;
+ int map_fd, sock_map_fd;
+ struct bpf_link *link;
int cg_fd = -1;
- int rv;
-
- cg_fd = cgroup_setup_and_join(CG_NAME);
- if (CHECK_FAIL(cg_fd < 0))
- goto err;
- if (CHECK_FAIL(bpf_prog_load(file, BPF_PROG_TYPE_SOCK_OPS, &obj, &prog_fd))) {
- fprintf(stderr, "FAILED: load_bpf_file failed for: %s\n", file);
- goto err;
- }
+ skel = test_tcpbpf_kern__open_and_load();
+ if (CHECK(!skel, "open and load skel", "failed"))
+ return;
- rv = bpf_prog_attach(prog_fd, cg_fd, BPF_CGROUP_SOCK_OPS, 0);
- if (CHECK_FAIL(rv)) {
- fprintf(stderr, "FAILED: bpf_prog_attach: %d (%s)\n",
- errno, strerror(errno));
- goto err;
- }
+ cg_fd = test__join_cgroup(CG_NAME);
+ if (CHECK_FAIL(cg_fd < 0))
+ goto cleanup_skel;
- map_fd = bpf_find_map(__func__, obj, "global_map");
- if (CHECK_FAIL(map_fd < 0))
- goto err;
+ map_fd = bpf_map__fd(skel->maps.global_map);
+ sock_map_fd = bpf_map__fd(skel->maps.sockopt_results);
- sock_map_fd = bpf_find_map(__func__, obj, "sockopt_results");
- if (CHECK_FAIL(sock_map_fd < 0))
- goto err;
+ link = bpf_program__attach_cgroup(skel->progs.bpf_testcb, cg_fd);
+ if (CHECK(IS_ERR(link), "attach_cgroup(estab)", "err: %ld\n",
+ PTR_ERR(link)))
+ goto cleanup_namespace;
run_test(map_fd, sock_map_fd);
-err:
- bpf_prog_detach(cg_fd, BPF_CGROUP_SOCK_OPS);
+
+ bpf_link__destroy(link);
+cleanup_namespace:
close(cg_fd);
- cleanup_cgroup_environment();
+cleanup_skel:
+ test_tcpbpf_kern__destroy(skel);
}
next prev parent reply other threads:[~2020-10-28 23:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 1:46 [bpf-next PATCH 0/4] selftests/bpf: Migrate test_tcpbpf_user to be a part of test_progs framework Alexander Duyck
2020-10-28 1:47 ` [bpf-next PATCH 1/4] selftests/bpf: Move test_tcppbf_user into test_progs Alexander Duyck
2020-10-29 23:27 ` Andrii Nakryiko
2020-10-30 0:39 ` Alexander Duyck
2020-10-28 1:47 ` [bpf-next PATCH 2/4] selftests/bpf: Drop python client/server in favor of threads Alexander Duyck
2020-10-29 1:51 ` Martin KaFai Lau
2020-10-29 16:58 ` Alexander Duyck
2020-10-29 18:12 ` Martin KaFai Lau
2020-10-29 19:51 ` Alexander Duyck
2020-10-28 1:47 ` [bpf-next PATCH 3/4] selftests/bpf: Replace EXPECT_EQ with ASSERT_EQ and refactor verify_results Alexander Duyck
2020-10-28 1:47 ` Alexander Duyck [this message]
2020-10-29 23:20 ` [bpf-next PATCH 4/4] selftests/bpf: Migrate tcpbpf_user.c to use BPF skeleton Andrii Nakryiko
2020-10-30 0:42 ` Alexander Duyck
2020-10-30 2:30 ` Andrii Nakryiko
2020-10-30 15:50 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160384964803.698509.11020605670605638967.stgit@localhost.localdomain \
--to=alexander.duyck@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brakmo@fb.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox