* [PATCH net] iavf: fix error return code in iavf_init_get_resources()
@ 2020-11-12 11:39 Zhang Changzhong
2020-11-12 22:17 ` Jesse Brandeburg
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Changzhong @ 2020-11-12 11:39 UTC (permalink / raw)
To: jesse.brandeburg, anthony.l.nguyen, davem, kuba, jakub.pawlak,
jeffrey.t.kirsher
Cc: netdev, linux-kernel
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: b66c7bc1cd4d ("iavf: Refactor init state machine")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 95543df..ff1102d 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -1776,7 +1776,8 @@ static int iavf_init_get_resources(struct iavf_adapter *adapter)
goto err_alloc;
}
- if (iavf_process_config(adapter))
+ err = iavf_process_config(adapter);
+ if (err)
goto err_alloc;
adapter->current_op = VIRTCHNL_OP_UNKNOWN;
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] iavf: fix error return code in iavf_init_get_resources()
2020-11-12 11:39 [PATCH net] iavf: fix error return code in iavf_init_get_resources() Zhang Changzhong
@ 2020-11-12 22:17 ` Jesse Brandeburg
0 siblings, 0 replies; 2+ messages in thread
From: Jesse Brandeburg @ 2020-11-12 22:17 UTC (permalink / raw)
To: Zhang Changzhong
Cc: anthony.l.nguyen, davem, kuba, jakub.pawlak, jeffrey.t.kirsher,
netdev, linux-kernel
Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: b66c7bc1cd4d ("iavf: Refactor init state machine")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Thanks!
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 22:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-12 11:39 [PATCH net] iavf: fix error return code in iavf_init_get_resources() Zhang Changzhong
2020-11-12 22:17 ` Jesse Brandeburg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).