From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58525C63697 for ; Mon, 16 Nov 2020 21:15:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12C252224F for ; Mon, 16 Nov 2020 21:15:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vgmAOVrI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731949AbgKPVPJ (ORCPT ); Mon, 16 Nov 2020 16:15:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:50960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbgKPVPG (ORCPT ); Mon, 16 Nov 2020 16:15:06 -0500 Received: from localhost (lfbn-tou-1-1075-236.w90-76.abo.wanadoo.fr [90.76.143.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3795C20888; Mon, 16 Nov 2020 21:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605561306; bh=KKKLqy05JpAvCjkxBFWdO5hMPGcadZx9kPhUbI8AJHA=; h=In-Reply-To:References:From:Subject:To:Cc:Date:From; b=vgmAOVrIK2rI8Dv6s6VoLfFghIVyDqzuR7OfxYPgXPJhZ+hBDjcdYC8e54afzzvHV gx6/qMloTBbQA147g6H+LxvAqQ4UhfJmdgXOMDaaxpLFRPE2vDwtoK+QWvwaB6yTzQ aXmEhacgnEle+TUydS51i8KvGTo8/x5vqWHaDML0= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: From: Antoine Tenart Subject: Re: [PATCH v2] net: phy: mscc: fix excluded_middle.cocci warnings To: Andrew Lunn , Antoine Tenart , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Julia Lawall , Russell King Cc: Quentin Schulz , kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Denis Efremov , netdev@vger.kernel.org Message-ID: <160556130103.369564.5641893167437988724@surface.local> Date: Mon, 16 Nov 2020 22:15:01 +0100 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello Julia, Quoting Julia Lawall (2020-11-16 16:34:44) > From: kernel test robot >=20 > Condition !A || A && B is equivalent to !A || B. >=20 > Generated by: scripts/coccinelle/misc/excluded_middle.cocci >=20 > Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script") > CC: Denis Efremov > Reported-by: kernel test robot > Signed-off-by: kernel test robot > Signed-off-by: Julia Lawall Reviewed-by: Antoine Tenart Thanks! Antoine > --- >=20 > v2: add netdev mailing list >=20 > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi= t master > head: e28c0d7c92c89016c12a677616668957351e7542 > commit: b76f0ea013125358d1b4ca147a6f9b6883dd2493 coccinelle: misc: add ex= cluded_middle.cocci script > :::::: branch date: 8 hours ago > :::::: commit date: 8 weeks ago >=20 > Please take the patch only if it's a positive warning. Thanks! >=20 > mscc_ptp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > --- a/drivers/net/phy/mscc/mscc_ptp.c > +++ b/drivers/net/phy/mscc/mscc_ptp.c > @@ -136,7 +136,7 @@ static void vsc85xx_ts_write_csr(struct >=20 > phy_ts_base_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_158= 8); >=20 > - if (!cond || (cond && upper)) > + if (!cond || upper) > phy_ts_base_write(phydev, MSCC_PHY_TS_CSR_DATA_MSB, upper= ); >=20 > phy_ts_base_write(phydev, MSCC_PHY_TS_CSR_DATA_LSB, lower);