From: patchwork-bot+netdevbpf@kernel.org
To: Ryan Sharpelletti <sharpelletti.kdev@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
sharpelletti@google.com, ncardwell@google.com, soheil@google.com,
ycheng@google.com
Subject: Re: [PATCH net] tcp: only postpone PROBE_RTT if RTT is < current min_rtt estimate
Date: Tue, 17 Nov 2020 19:10:05 +0000 [thread overview]
Message-ID: <160564020504.18685.6007226279853595659.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20201116174412.1433277-1-sharpelletti.kdev@gmail.com>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Mon, 16 Nov 2020 17:44:13 +0000 you wrote:
> From: Ryan Sharpelletti <sharpelletti@google.com>
>
> During loss recovery, retransmitted packets are forced to use TCP
> timestamps to calculate the RTT samples, which have a millisecond
> granularity. BBR is designed using a microsecond granularity. As a
> result, multiple RTT samples could be truncated to the same RTT value
> during loss recovery. This is problematic, as BBR will not enter
> PROBE_RTT if the RTT sample is <= the current min_rtt sample, meaning
> that if there are persistent losses, PROBE_RTT will constantly be
> pushed off and potentially never re-entered. This patch makes sure
> that BBR enters PROBE_RTT by checking if RTT sample is < the current
> min_rtt sample, rather than <=.
>
> [...]
Here is the summary with links:
- [net] tcp: only postpone PROBE_RTT if RTT is < current min_rtt estimate
https://git.kernel.org/netdev/net/c/1b9e2a8c99a5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2020-11-17 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 17:44 [PATCH net] tcp: only postpone PROBE_RTT if RTT is < current min_rtt estimate Ryan Sharpelletti
2020-11-16 17:58 ` Soheil Hassas Yeganeh
2020-11-17 19:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160564020504.18685.6007226279853595659.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=sharpelletti.kdev@gmail.com \
--cc=sharpelletti@google.com \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).