From: Jesper Dangaard Brouer <brouer@redhat.com>
To: bpf@vger.kernel.org
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
netdev@vger.kernel.org, Daniel Borkmann <borkmann@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
maze@google.com, lmb@cloudflare.com, shaun@tigera.io,
Lorenzo Bianconi <lorenzo@kernel.org>,
marek@cloudflare.com, John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
eyal.birger@gmail.com, colrack@gmail.com
Subject: [PATCH bpf-next V6 0/7] bpf: New approach for BPF MTU handling
Date: Wed, 18 Nov 2020 16:29:25 +0100 [thread overview]
Message-ID: <160571331409.2801246.11527010115263068327.stgit@firesoul> (raw)
This patchset drops all the MTU checks in TC BPF-helpers that limits
growing the packet size. This is done because these BPF-helpers doesn't
take redirect into account, which can result in their MTU check being done
against the wrong netdev.
The new approach is to give BPF-programs knowledge about the MTU on a
netdev (via ifindex) and fib route lookup level. Meaning some BPF-helpers
are added and extended to make it possible to do MTU checks in the
BPF-code.
If BPF-prog doesn't comply with the MTU then the packet will eventually
get dropped as some other layer. In some cases the existing kernel MTU
checks will drop the packet, but there are also cases where BPF can bypass
these checks. Specifically doing TC-redirect from ingress step
(sch_handle_ingress) into egress code path (basically calling
dev_queue_xmit()). It is left up to driver code to handle these kind of
MTU violations.
One advantage of this approach is that it ingress-to-egress BPF-prog can
send information via packet data. With the MTU checks removed in the
helpers, and also not done in skb_do_redirect() call, this allows for an
ingress BPF-prog to communicate with an egress BPF-prog via packet data,
as long as egress BPF-prog remove this prior to transmitting packet.
This patchset is primarily focused on TC-BPF, but I've made sure that the
MTU BPF-helpers also works for XDP BPF-programs.
V2: Change BPF-helper API from lookup to check.
V3: Drop enforcement of MTU in net-core, leave it to drivers.
V4: Keep sanity limit + netdev "up" checks + rename BPF-helper.
V5: Fix uninit variable + name struct output member mtu_result.
V6: Use bpf_check_mtu() in selftest
---
Jesper Dangaard Brouer (7):
bpf: Remove MTU check in __bpf_skb_max_len
bpf: fix bpf_fib_lookup helper MTU check for SKB ctx
bpf: bpf_fib_lookup return MTU value as output when looked up
bpf: add BPF-helper for MTU checking
bpf: drop MTU check when doing TC-BPF redirect to ingress
bpf: make it possible to identify BPF redirected SKBs
selftests/bpf: use bpf_check_mtu in selftest test_cls_redirect
include/linux/netdevice.h | 31 +++
include/uapi/linux/bpf.h | 78 ++++++++-
net/core/dev.c | 21 --
net/core/filter.c | 182 ++++++++++++++++++--
net/sched/Kconfig | 1
tools/include/uapi/linux/bpf.h | 78 ++++++++-
.../selftests/bpf/progs/test_cls_redirect.c | 7 +
7 files changed, 356 insertions(+), 42 deletions(-)
--
next reply other threads:[~2020-11-18 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 15:29 Jesper Dangaard Brouer [this message]
2020-11-18 15:29 ` [PATCH bpf-next V6 1/7] bpf: Remove MTU check in __bpf_skb_max_len Jesper Dangaard Brouer
2020-11-18 15:29 ` [PATCH bpf-next V6 2/7] bpf: fix bpf_fib_lookup helper MTU check for SKB ctx Jesper Dangaard Brouer
2020-11-20 8:26 ` Jesper Dangaard Brouer
2020-11-20 13:15 ` Carlo Carraro
2020-11-20 15:53 ` David Ahern
2020-11-18 15:29 ` [PATCH bpf-next V6 3/7] bpf: bpf_fib_lookup return MTU value as output when looked up Jesper Dangaard Brouer
2020-11-18 15:29 ` [PATCH bpf-next V6 4/7] bpf: add BPF-helper for MTU checking Jesper Dangaard Brouer
2020-11-18 15:29 ` [PATCH bpf-next V6 5/7] bpf: drop MTU check when doing TC-BPF redirect to ingress Jesper Dangaard Brouer
2020-11-18 15:29 ` [PATCH bpf-next V6 6/7] bpf: make it possible to identify BPF redirected SKBs Jesper Dangaard Brouer
2020-11-18 15:30 ` [PATCH bpf-next V6 7/7] selftests/bpf: use bpf_check_mtu in selftest test_cls_redirect Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160571331409.2801246.11527010115263068327.stgit@firesoul \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=colrack@gmail.com \
--cc=eyal.birger@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lmb@cloudflare.com \
--cc=lorenzo@kernel.org \
--cc=marek@cloudflare.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=shaun@tigera.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox