From: Pkshih <pkshih@realtek.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony0620emma@gmail.com" <tony0620emma@gmail.com>,
"zhengyongjun3@huawei.com" <zhengyongjun3@huawei.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH wireless -next] rtw88: Delete useless kfree code
Date: Thu, 17 Dec 2020 00:55:12 +0000 [thread overview]
Message-ID: <1608166499.2560.0.camel@realtek.com> (raw)
In-Reply-To: <20201216130442.13869-1-zhengyongjun3@huawei.com>
On Wed, 2020-12-16 at 13:04 +0000, Zheng Yongjun wrote:
> The parameter of kfree function is NULL, so kfree code is useless, delete it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw88/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/main.c
> b/drivers/net/wireless/realtek/rtw88/main.c
> index 565efd880624..15568cd670a3 100644
> --- a/drivers/net/wireless/realtek/rtw88/main.c
> +++ b/drivers/net/wireless/realtek/rtw88/main.c
> @@ -1249,7 +1249,6 @@ static void rtw_set_supported_band(struct ieee80211_hw
> *hw,
>
> err_out:
> rtw_err(rtwdev, "failed to set supported band\n");
> - kfree(sband);
> }
>
> static void rtw_unset_supported_band(struct ieee80211_hw *hw,
next prev parent reply other threads:[~2020-12-17 0:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 13:04 [PATCH wireless -next] rtw88: Delete useless kfree code Zheng Yongjun
2020-12-17 0:55 ` Pkshih [this message]
2021-01-14 17:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608166499.2560.0.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony0620emma@gmail.com \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).