netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pkshih <pkshih@realtek.com>
To: "abaci-bugfix@linux.alibaba.com" <abaci-bugfix@linux.alibaba.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] wireless: realtek: Simplify bool comparison
Date: Tue, 12 Jan 2021 13:25:48 +0000	[thread overview]
Message-ID: <1610457909.2793.7.camel@realtek.com> (raw)
In-Reply-To: <1610440751-79543-1-git-send-email-abaci-bugfix@linux.alibaba.com>

On Tue, 2021-01-12 at 16:39 +0800, YANG LI wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtlwifi/ps.c:803:7-21: WARNING:
> Comparison to bool
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
> ---
>  drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/ps.c
> b/drivers/net/wireless/realtek/rtlwifi/ps.c
> index f9988225..629c032 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/ps.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/ps.c
> @@ -798,9 +798,9 @@ static void rtl_p2p_noa_ie(struct ieee80211_hw *hw, void
> *data,
>  		ie += 3 + noa_len;
>  	}
>  
> -	if (find_p2p_ie == true) {
> +	if (find_p2p_ie) {
>  		if ((p2pinfo->p2p_ps_mode > P2P_PS_NONE) &&
> -		    (find_p2p_ps_ie == false))
> +		    (!find_p2p_ps_ie))
>  			rtl_p2p_ps_cmd(hw, P2P_PS_DISABLE);
>  	}
>  }

The subject prefix should be "rtlwifi:".
And, I think it's ok to merge this patch with another patch 
("rtlwifi: rtl8821ae: style: Simplify bool comparison").
Because both of them are trivial fixes and belong to rtlwifi.

---
Ping-Ke


      reply	other threads:[~2021-01-12 13:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  8:39 [PATCH] wireless: realtek: Simplify bool comparison YANG LI
2021-01-12 13:25 ` Pkshih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1610457909.2793.7.camel@realtek.com \
    --to=pkshih@realtek.com \
    --cc=abaci-bugfix@linux.alibaba.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).