* [PATCH net] ch_ipsec: Remove initialization of rxq related data
@ 2021-01-13 4:43 Ayush Sawal
2021-01-14 18:42 ` Jakub Kicinski
2021-01-15 2:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Ayush Sawal @ 2021-01-13 4:43 UTC (permalink / raw)
To: netdev, davem, kuba; +Cc: secdev, Ayush Sawal
Removing initialization of nrxq and rxq_size in uld_info. As
ipsec uses nic queues only, there is no need to create uld
rx queues for ipsec.
Fixes: 1b77be463929e ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net")
Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com>
---
.../net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c b/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c
index 47d9268a7e3c..585590520076 100644
--- a/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c
+++ b/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c
@@ -92,9 +92,6 @@ static const struct xfrmdev_ops ch_ipsec_xfrmdev_ops = {
static struct cxgb4_uld_info ch_ipsec_uld_info = {
.name = CHIPSEC_DRV_MODULE_NAME,
- .nrxq = MAX_ULD_QSETS,
- /* Max ntxq will be derived from fw config file*/
- .rxq_size = 1024,
.add = ch_ipsec_uld_add,
.state_change = ch_ipsec_uld_state_change,
.tx_handler = ch_ipsec_xmit,
--
2.28.0.rc1.6.gae46588
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] ch_ipsec: Remove initialization of rxq related data
2021-01-13 4:43 [PATCH net] ch_ipsec: Remove initialization of rxq related data Ayush Sawal
@ 2021-01-14 18:42 ` Jakub Kicinski
2021-01-15 2:16 ` Ayush Sawal
2021-01-15 2:20 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2021-01-14 18:42 UTC (permalink / raw)
To: Ayush Sawal; +Cc: netdev, davem, secdev
On Wed, 13 Jan 2021 10:13:02 +0530 Ayush Sawal wrote:
> Removing initialization of nrxq and rxq_size in uld_info. As
> ipsec uses nic queues only, there is no need to create uld
> rx queues for ipsec.
Why is this a fix? Does it break something or just wastes resources?
If it's just about efficient use of resources I'll apply to net-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] ch_ipsec: Remove initialization of rxq related data
2021-01-14 18:42 ` Jakub Kicinski
@ 2021-01-15 2:16 ` Ayush Sawal
0 siblings, 0 replies; 4+ messages in thread
From: Ayush Sawal @ 2021-01-15 2:16 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: ayush.sawal, netdev, davem, secdev
Hi Jakub,
On 1/15/2021 12:12 AM, Jakub Kicinski wrote:
> On Wed, 13 Jan 2021 10:13:02 +0530 Ayush Sawal wrote:
>> Removing initialization of nrxq and rxq_size in uld_info. As
>> ipsec uses nic queues only, there is no need to create uld
>> rx queues for ipsec.
> Why is this a fix? Does it break something or just wastes resources?
> If it's just about efficient use of resources I'll apply to net-next.
yes this patch is about efficient use of resources, please apply it to
net-next.
Thanks,
Ayush
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] ch_ipsec: Remove initialization of rxq related data
2021-01-13 4:43 [PATCH net] ch_ipsec: Remove initialization of rxq related data Ayush Sawal
2021-01-14 18:42 ` Jakub Kicinski
@ 2021-01-15 2:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-01-15 2:20 UTC (permalink / raw)
To: Ayush Sawal; +Cc: netdev, davem, kuba, secdev
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 13 Jan 2021 10:13:02 +0530 you wrote:
> Removing initialization of nrxq and rxq_size in uld_info. As
> ipsec uses nic queues only, there is no need to create uld
> rx queues for ipsec.
>
> Fixes: 1b77be463929e ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net")
> Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com>
>
> [...]
Here is the summary with links:
- [net] ch_ipsec: Remove initialization of rxq related data
https://git.kernel.org/netdev/net-next/c/e3a7670737ec
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-15 2:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-13 4:43 [PATCH net] ch_ipsec: Remove initialization of rxq related data Ayush Sawal
2021-01-14 18:42 ` Jakub Kicinski
2021-01-15 2:16 ` Ayush Sawal
2021-01-15 2:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).