[net] net: decnet: fix netdev refcount leaking on error path

[net] net: decnet: fix netdev refcount leaking on error path

[Vadim Fedorenko]

On building the route there is an assumption that the destination
could be local. In this case loopback_dev is used to get the address.
If the address is still cannot be retrieved dn_route_output_slow
returns EADDRNOTAVAIL with loopback_dev reference taken.

Cannot find hash for the fixes tag because this code was introduced
long time ago. I don't think that this bug has ever fired but the
patch is done just to have a consistent code base.

Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
---
 net/decnet/dn_route.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index 4cac31d..2193ae5 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -1035,7 +1035,7 @@ static int dn_route_output_slow(struct dst_entry **pprt, const struct flowidn *o
 			fld.saddr = dnet_select_source(dev_out, 0,
 						       RT_SCOPE_HOST);
 			if (!fld.daddr)
-				goto out;
+				goto done;
 		}
 		fld.flowidn_oif = LOOPBACK_IFINDEX;
 		res.type = RTN_LOCAL;
-- 
1.8.3.1

Re: [net] net: decnet: fix netdev refcount leaking on error path

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue, 26 Jan 2021 03:02:14 +0300 you wrote:
> On building the route there is an assumption that the destination
> could be local. In this case loopback_dev is used to get the address.
> If the address is still cannot be retrieved dn_route_output_slow
> returns EADDRNOTAVAIL with loopback_dev reference taken.
> 
> Cannot find hash for the fixes tag because this code was introduced
> long time ago. I don't think that this bug has ever fired but the
> patch is done just to have a consistent code base.
> 
> [...]

Here is the summary with links:
  - [net] net: decnet: fix netdev refcount leaking on error path
    https://git.kernel.org/netdev/net/c/3f96d6449768

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html