* [PATCH v2] perf script: Simplify bool conversion
@ 2021-02-08 8:45 Yang Li
2021-02-09 12:47 ` Jiri Olsa
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-02-08 8:45 UTC (permalink / raw)
To: daniel
Cc: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
namhyung, ast, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, linux-kernel, netdev, bpf, Yang Li
Fix the following coccicheck warning:
./tools/perf/builtin-script.c:2789:36-41: WARNING: conversion to bool
not needed here
./tools/perf/builtin-script.c:3237:48-53: WARNING: conversion to bool
not needed here
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
Change in v2:
-Change the subject to "perf script"
tools/perf/builtin-script.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 42dad4a..3646a1c 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2786,7 +2786,7 @@ static int parse_output_fields(const struct option *opt __maybe_unused,
break;
}
if (i == imax && strcmp(tok, "flags") == 0) {
- print_flags = change == REMOVE ? false : true;
+ print_flags = change != REMOVE;
continue;
}
if (i == imax) {
@@ -3234,7 +3234,7 @@ static char *get_script_path(const char *script_root, const char *suffix)
static bool is_top_script(const char *script_path)
{
- return ends_with(script_path, "top") == NULL ? false : true;
+ return ends_with(script_path, "top") != NULL;
}
static int has_required_arg(char *script_path)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] perf script: Simplify bool conversion
2021-02-08 8:45 [PATCH v2] perf script: Simplify bool conversion Yang Li
@ 2021-02-09 12:47 ` Jiri Olsa
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Olsa @ 2021-02-09 12:47 UTC (permalink / raw)
To: Yang Li
Cc: daniel, peterz, mingo, acme, mark.rutland, alexander.shishkin,
namhyung, ast, andrii, kafai, songliubraving, yhs, john.fastabend,
kpsingh, linux-kernel, netdev, bpf
On Mon, Feb 08, 2021 at 04:45:36PM +0800, Yang Li wrote:
> Fix the following coccicheck warning:
> ./tools/perf/builtin-script.c:2789:36-41: WARNING: conversion to bool
> not needed here
> ./tools/perf/builtin-script.c:3237:48-53: WARNING: conversion to bool
> not needed here
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
> ---
>
> Change in v2:
> -Change the subject to "perf script"
>
> tools/perf/builtin-script.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 42dad4a..3646a1c 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -2786,7 +2786,7 @@ static int parse_output_fields(const struct option *opt __maybe_unused,
> break;
> }
> if (i == imax && strcmp(tok, "flags") == 0) {
> - print_flags = change == REMOVE ? false : true;
> + print_flags = change != REMOVE;
> continue;
> }
> if (i == imax) {
> @@ -3234,7 +3234,7 @@ static char *get_script_path(const char *script_root, const char *suffix)
>
> static bool is_top_script(const char *script_path)
> {
> - return ends_with(script_path, "top") == NULL ? false : true;
> + return ends_with(script_path, "top") != NULL;
> }
>
> static int has_required_arg(char *script_path)
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-09 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-08 8:45 [PATCH v2] perf script: Simplify bool conversion Yang Li
2021-02-09 12:47 ` Jiri Olsa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).