From: patchwork-bot+netdevbpf@kernel.org
To: Edwin Peer <edwin.peer@broadcom.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
andrew.gospodarek@broadcom.com, michael.chan@broadcom.com
Subject: Re: [PATCH net] net: watchdog: hold device global xmit lock during tx disable
Date: Tue, 09 Feb 2021 00:30:08 +0000 [thread overview]
Message-ID: <161283060802.30880.13274297452987698387.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210206013732.508552-1-edwin.peer@broadcom.com>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Feb 2021 17:37:32 -0800 you wrote:
> Prevent netif_tx_disable() running concurrently with dev_watchdog() by
> taking the device global xmit lock. Otherwise, the recommended:
>
> netif_carrier_off(dev);
> netif_tx_disable(dev);
>
> driver shutdown sequence can happen after the watchdog has already
> checked carrier, resulting in possible false alarms. This is because
> netif_tx_lock() only sets the frozen bit without maintaining the locks
> on the individual queues.
>
> [...]
Here is the summary with links:
- [net] net: watchdog: hold device global xmit lock during tx disable
https://git.kernel.org/netdev/net/c/3aa6bce9af0e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-02-09 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 1:37 [PATCH net] net: watchdog: hold device global xmit lock during tx disable Edwin Peer
2021-02-08 20:01 ` Jakub Kicinski
2021-02-09 0:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161283060802.30880.13274297452987698387.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=edwin.peer@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).