From: patchwork-bot+netdevbpf@kernel.org
To: Marco Elver <elver@google.com>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
paulmck@kernel.org, dvyukov@google.com,
syzbot+3536db46dfa58c573458@syzkaller.appspotmail.com,
syzbot+516acdb03d3e27d91bcd@syzkaller.appspotmail.com
Subject: Re: [PATCH] bpf_lru_list: Read double-checked variable once without lock
Date: Thu, 11 Feb 2021 00:00:07 +0000 [thread overview]
Message-ID: <161300160716.412.6891143842651326044.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210209112701.3341724-1-elver@google.com>
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Tue, 9 Feb 2021 12:27:01 +0100 you wrote:
> For double-checked locking in bpf_common_lru_push_free(), node->type is
> read outside the critical section and then re-checked under the lock.
> However, concurrent writes to node->type result in data races.
>
> For example, the following concurrent access was observed by KCSAN:
>
> write to 0xffff88801521bc22 of 1 bytes by task 10038 on cpu 1:
> __bpf_lru_node_move_in kernel/bpf/bpf_lru_list.c:91
> __local_list_flush kernel/bpf/bpf_lru_list.c:298
> ...
> read to 0xffff88801521bc22 of 1 bytes by task 10043 on cpu 0:
> bpf_common_lru_push_free kernel/bpf/bpf_lru_list.c:507
> bpf_lru_push_free kernel/bpf/bpf_lru_list.c:555
> ...
>
> [...]
Here is the summary with links:
- bpf_lru_list: Read double-checked variable once without lock
https://git.kernel.org/bpf/bpf-next/c/6df8fb83301d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-02-11 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 11:27 [PATCH] bpf_lru_list: Read double-checked variable once without lock Marco Elver
2021-02-10 5:59 ` Martin KaFai Lau
2021-02-10 23:56 ` Andrii Nakryiko
2021-02-11 0:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161300160716.412.6891143842651326044.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kasan-dev@googlegroups.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=songliubraving@fb.com \
--cc=syzbot+3536db46dfa58c573458@syzkaller.appspotmail.com \
--cc=syzbot+516acdb03d3e27d91bcd@syzkaller.appspotmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).