* [PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x
2021-02-28 20:24 [PATCH net 0/3] Fix TRSCER masks in the Ether driver Sergey Shtylyov
@ 2021-02-28 20:25 ` Sergey Shtylyov
2021-03-04 8:42 ` Geert Uytterhoeven
2021-02-28 20:26 ` [PATCH net 2/3] sh_eth: fix TRSCER mask for R7S72100 Sergey Shtylyov
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Sergey Shtylyov @ 2021-02-28 20:25 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, netdev@vger.kernel.org; +Cc: linux-renesas-soc
According to the SH7710, SH7712, SH7713 Group User's Manual: Hardware,
Rev. 3.00, the TRSCER register actually has only bit 7 valid (and named
differently), with all the other bits reserved. Apparently, this was not
the case with some early revisions of the manual as we have the other
bits declared (and set) in the original driver. Follow the suit and add
the explicit sh_eth_cpu_data::trscer_err_mask initializer for SH771x...
Fixes: 86a74ff21a7a ("net: sh_eth: add support for Renesas SuperH Ethernet")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
---
drivers/net/ethernet/renesas/sh_eth.c | 3 +++
1 file changed, 3 insertions(+)
Index: net/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net/drivers/net/ethernet/renesas/sh_eth.c
@@ -1089,6 +1089,9 @@ static struct sh_eth_cpu_data sh771x_dat
EESIPR_CEEFIP | EESIPR_CELFIP |
EESIPR_RRFIP | EESIPR_RTLFIP | EESIPR_RTSFIP |
EESIPR_PREIP | EESIPR_CERFIP,
+
+ .trscer_err_mask = DESC_I_RINT8,
+
.tsu = 1,
.dual_port = 1,
};
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x
2021-02-28 20:25 ` [PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x Sergey Shtylyov
@ 2021-03-04 8:42 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2021-03-04 8:42 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: David S. Miller, Jakub Kicinski, netdev@vger.kernel.org,
Linux-Renesas
On Sun, Feb 28, 2021 at 9:54 PM Sergey Shtylyov <s.shtylyov@omprussia.ru> wrote:
> According to the SH7710, SH7712, SH7713 Group User's Manual: Hardware,
> Rev. 3.00, the TRSCER register actually has only bit 7 valid (and named
> differently), with all the other bits reserved. Apparently, this was not
> the case with some early revisions of the manual as we have the other
> bits declared (and set) in the original driver. Follow the suit and add
> the explicit sh_eth_cpu_data::trscer_err_mask initializer for SH771x...
>
> Fixes: 86a74ff21a7a ("net: sh_eth: add support for Renesas SuperH Ethernet")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH net 2/3] sh_eth: fix TRSCER mask for R7S72100
2021-02-28 20:24 [PATCH net 0/3] Fix TRSCER masks in the Ether driver Sergey Shtylyov
2021-02-28 20:25 ` [PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x Sergey Shtylyov
@ 2021-02-28 20:26 ` Sergey Shtylyov
2021-03-04 8:44 ` Geert Uytterhoeven
2021-02-28 20:27 ` [PATCH net 3/3] sh_eth: fix TRSCER mask for R7S9210 Sergey Shtylyov
2021-03-01 21:30 ` [PATCH net 0/3] Fix TRSCER masks in the Ether driver patchwork-bot+netdevbpf
3 siblings, 1 reply; 9+ messages in thread
From: Sergey Shtylyov @ 2021-02-28 20:26 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, netdev@vger.kernel.org; +Cc: linux-renesas-soc
According to the RZ/A1H Group, RZ/A1M Group User's Manual: Hardware,
Rev. 4.00, the TRSCER register has bit 9 reserved, hence we can't use
the driver's default TRSCER mask. Add the explicit initializer for
sh_eth_cpu_data::trscer_err_mask for R7S72100.
Fixes: db893473d313 ("sh_eth: Add support for r7s72100")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
---
drivers/net/ethernet/renesas/sh_eth.c | 2 ++
1 file changed, 2 insertions(+)
Index: net/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net/drivers/net/ethernet/renesas/sh_eth.c
@@ -560,6 +560,8 @@ static struct sh_eth_cpu_data r7s72100_d
EESR_TDE,
.fdr_value = 0x0000070f,
+ .trscer_err_mask = DESC_I_RINT8 | DESC_I_RINT5,
+
.no_psr = 1,
.apr = 1,
.mpr = 1,
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH net 2/3] sh_eth: fix TRSCER mask for R7S72100
2021-02-28 20:26 ` [PATCH net 2/3] sh_eth: fix TRSCER mask for R7S72100 Sergey Shtylyov
@ 2021-03-04 8:44 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2021-03-04 8:44 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: David S. Miller, Jakub Kicinski, netdev@vger.kernel.org,
Linux-Renesas
On Sun, Feb 28, 2021 at 9:54 PM Sergey Shtylyov <s.shtylyov@omprussia.ru> wrote:
> According to the RZ/A1H Group, RZ/A1M Group User's Manual: Hardware,
> Rev. 4.00, the TRSCER register has bit 9 reserved, hence we can't use
> the driver's default TRSCER mask. Add the explicit initializer for
> sh_eth_cpu_data::trscer_err_mask for R7S72100.
>
> Fixes: db893473d313 ("sh_eth: Add support for r7s72100")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH net 3/3] sh_eth: fix TRSCER mask for R7S9210
2021-02-28 20:24 [PATCH net 0/3] Fix TRSCER masks in the Ether driver Sergey Shtylyov
2021-02-28 20:25 ` [PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x Sergey Shtylyov
2021-02-28 20:26 ` [PATCH net 2/3] sh_eth: fix TRSCER mask for R7S72100 Sergey Shtylyov
@ 2021-02-28 20:27 ` Sergey Shtylyov
2021-03-04 8:51 ` Geert Uytterhoeven
2021-03-01 21:30 ` [PATCH net 0/3] Fix TRSCER masks in the Ether driver patchwork-bot+netdevbpf
3 siblings, 1 reply; 9+ messages in thread
From: Sergey Shtylyov @ 2021-02-28 20:27 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, netdev@vger.kernel.org; +Cc: linux-renesas-soc
According to the RZ/A2M Group User's Manual: Hardware, Rev. 2.00,
the TRSCER register has bit 9 reserved, hence we can't use the driver's
default TRSCER mask. Add the explicit initializer for sh_eth_cpu_data::
trscer_err_mask for R7S9210.
Fixes: 6e0bb04d0e4f ("sh_eth: Add R7S9210 support")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
---
drivers/net/ethernet/renesas/sh_eth.c | 2 ++
1 file changed, 2 insertions(+)
Index: net/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net/drivers/net/ethernet/renesas/sh_eth.c
@@ -782,6 +782,8 @@ static struct sh_eth_cpu_data r7s9210_da
.fdr_value = 0x0000070f,
+ .trscer_err_mask = DESC_I_RINT8 | DESC_I_RINT5,
+
.apr = 1,
.mpr = 1,
.tpauser = 1,
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH net 3/3] sh_eth: fix TRSCER mask for R7S9210
2021-02-28 20:27 ` [PATCH net 3/3] sh_eth: fix TRSCER mask for R7S9210 Sergey Shtylyov
@ 2021-03-04 8:51 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2021-03-04 8:51 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: David S. Miller, Jakub Kicinski, netdev@vger.kernel.org,
Linux-Renesas
On Sun, Feb 28, 2021 at 9:56 PM Sergey Shtylyov <s.shtylyov@omprussia.ru> wrote:
> According to the RZ/A2M Group User's Manual: Hardware, Rev. 2.00,
> the TRSCER register has bit 9 reserved, hence we can't use the driver's
> default TRSCER mask. Add the explicit initializer for sh_eth_cpu_data::
> trscer_err_mask for R7S9210.
>
> Fixes: 6e0bb04d0e4f ("sh_eth: Add R7S9210 support")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net 0/3] Fix TRSCER masks in the Ether driver
2021-02-28 20:24 [PATCH net 0/3] Fix TRSCER masks in the Ether driver Sergey Shtylyov
` (2 preceding siblings ...)
2021-02-28 20:27 ` [PATCH net 3/3] sh_eth: fix TRSCER mask for R7S9210 Sergey Shtylyov
@ 2021-03-01 21:30 ` patchwork-bot+netdevbpf
2021-03-02 16:32 ` Geert Uytterhoeven
3 siblings, 1 reply; 9+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-01 21:30 UTC (permalink / raw)
To: Sergey Shtylyov; +Cc: davem, kuba, netdev, linux-renesas-soc
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Sun, 28 Feb 2021 23:24:16 +0300 you wrote:
> Here are 3 patches against DaveM's 'net' repo. I'm fixing the TRSCER masks in
> the driver to match the manuals...
>
> [1/3] sh_eth: fix TRSCER mask for SH771x
> [2/3] sh_eth: fix TRSCER mask for R7S72100
> [3/3] sh_eth: fix TRSCER mask for R7S9210
Here is the summary with links:
- [net,1/3] sh_eth: fix TRSCER mask for SH771x
https://git.kernel.org/netdev/net/c/8c91bc3d44df
- [net,2/3] sh_eth: fix TRSCER mask for R7S72100
https://git.kernel.org/netdev/net/c/75be7fb7f978
- [net,3/3] sh_eth: fix TRSCER mask for R7S9210
https://git.kernel.org/netdev/net/c/165bc5a4f30e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH net 0/3] Fix TRSCER masks in the Ether driver
2021-03-01 21:30 ` [PATCH net 0/3] Fix TRSCER masks in the Ether driver patchwork-bot+netdevbpf
@ 2021-03-02 16:32 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2021-03-02 16:32 UTC (permalink / raw)
To: patchwork-bot+netdevbpf
Cc: Sergey Shtylyov, David S. Miller, Jakub Kicinski, netdev,
Linux-Renesas
On Mon, Mar 1, 2021 at 10:38 PM <patchwork-bot+netdevbpf@kernel.org> wrote:
> This series was applied to netdev/net.git (refs/heads/master):
>
> On Sun, 28 Feb 2021 23:24:16 +0300 you wrote:
> > Here are 3 patches against DaveM's 'net' repo. I'm fixing the TRSCER masks in
> > the driver to match the manuals...
> >
> > [1/3] sh_eth: fix TRSCER mask for SH771x
> > [2/3] sh_eth: fix TRSCER mask for R7S72100
> > [3/3] sh_eth: fix TRSCER mask for R7S9210
>
> Here is the summary with links:
> - [net,1/3] sh_eth: fix TRSCER mask for SH771x
> https://git.kernel.org/netdev/net/c/8c91bc3d44df
> - [net,2/3] sh_eth: fix TRSCER mask for R7S72100
> https://git.kernel.org/netdev/net/c/75be7fb7f978
> - [net,3/3] sh_eth: fix TRSCER mask for R7S9210
> https://git.kernel.org/netdev/net/c/165bc5a4f30e
That was quick. And as they're queued in net, not net-next, they
missed today's renesas-drivers release, and all related testing...
I applied them manually, and boot-tested rskrza1 (R7S72100) and
rza2mevb (R7S9210) using nfsroot. Worked fine.
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Review will take a bit longer...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread