From: patchwork-bot+netdevbpf@kernel.org
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
zbynek.michl@gmail.com, chris.snook@gmail.com,
bruceshenzk@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH net] ethernet: alx: fix order of calls on resume
Date: Fri, 05 Mar 2021 23:10:11 +0000 [thread overview]
Message-ID: <161498581110.14945.17599653986246768706.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210305221729.206096-1-kuba@kernel.org>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Mar 2021 14:17:29 -0800 you wrote:
> netif_device_attach() will unpause the queues so we can't call
> it before __alx_open(). This went undetected until
> commit b0999223f224 ("alx: add ability to allocate and free
> alx_napi structures") but now if stack tries to xmit immediately
> on resume before __alx_open() we'll crash on the NAPI being null:
>
> BUG: kernel NULL pointer dereference, address: 0000000000000198
> CPU: 0 PID: 12 Comm: ksoftirqd/0 Tainted: G OE 5.10.0-3-amd64 #1 Debian 5.10.13-1
> Hardware name: Gigabyte Technology Co., Ltd. To be filled by O.E.M./H77-D3H, BIOS F15 11/14/2013
> RIP: 0010:alx_start_xmit+0x34/0x650 [alx]
> Code: 41 56 41 55 41 54 55 53 48 83 ec 20 0f b7 57 7c 8b 8e b0
> 0b 00 00 39 ca 72 06 89 d0 31 d2 f7 f1 89 d2 48 8b 84 df
> RSP: 0018:ffffb09240083d28 EFLAGS: 00010297
> RAX: 0000000000000000 RBX: ffffa04d80ae7800 RCX: 0000000000000004
> RDX: 0000000000000000 RSI: ffffa04d80afa000 RDI: ffffa04e92e92a00
> RBP: 0000000000000042 R08: 0000000000000100 R09: ffffa04ea3146700
> R10: 0000000000000014 R11: 0000000000000000 R12: ffffa04e92e92100
> R13: 0000000000000001 R14: ffffa04e92e92a00 R15: ffffa04e92e92a00
> FS: 0000000000000000(0000) GS:ffffa0508f600000(0000) knlGS:0000000000000000
> i915 0000:00:02.0: vblank wait timed out on crtc 0
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000000000198 CR3: 000000004460a001 CR4: 00000000001706f0
> Call Trace:
> dev_hard_start_xmit+0xc7/0x1e0
> sch_direct_xmit+0x10f/0x310
>
> [...]
Here is the summary with links:
- [net] ethernet: alx: fix order of calls on resume
https://git.kernel.org/netdev/net/c/a4dcfbc4ee22
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-03-05 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 22:17 [PATCH net] ethernet: alx: fix order of calls on resume Jakub Kicinski
2021-03-05 22:19 ` Jakub Kicinski
2021-03-05 23:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161498581110.14945.17599653986246768706.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bruceshenzk@gmail.com \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=zbynek.michl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox