From: Alexander Duyck <alexander.duyck@gmail.com>
To: kuba@kernel.org
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
simon.horman@netronome.com, yisen.zhuang@huawei.com,
salil.mehta@huawei.com, intel-wired-lan@lists.osuosl.org,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
drivers@pensando.io, snelson@pensando.io, netanel@amazon.com,
akiyano@amazon.com, gtzalik@amazon.com, saeedb@amazon.com,
GR-Linux-NIC-Dev@marvell.com, skalluru@marvell.com,
rmody@marvell.com, kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org, mst@redhat.com,
jasowang@redhat.com, pv-drivers@vmware.com, doshir@vmware.com,
alexanderduyck@fb.com
Subject: [RFC PATCH 00/10] ethtool: Factor out common code related to writing ethtool strings
Date: Wed, 10 Mar 2021 17:35:08 -0800 [thread overview]
Message-ID: <161542634192.13546.4185974647834631704.stgit@localhost.localdomain> (raw)
This patch set is meant to be a cleanup and refactoring of common code bits
from several drivers. Specificlly a number of drivers engage in a pattern
where they will use some variant on an sprintf or memcpy to write a string
into the ethtool string array and then they will increment their pointer by
ETH_GSTRING_LEN.
Instead of having each driver implement this independently I am refactoring
the code so that we have one central function, ethtool_gsprintf that does
all this whch takes a double pointer to access the data, a formatted string
to print, and the variable arguments that are associated with the string.
---
Alexander Duyck (10):
ethtool: Add common function for filling out strings
intel: Update drivers to use ethtool_gsprintf
nfp: Replace nfp_pr_et with ethtool_gsprintf
hisilicon: Update drivers to use ethtool_gsprintf
ena: Update driver to use ethtool_gsprintf
netvsc: Update driver to use ethtool_gsprintf
virtio_net: Update driver to use ethtool_gsprintf
vmxnet3: Update driver to use ethtool_gsprintf
bna: Update driver to use ethtool_gsprintf
ionic: Update driver to use ethtool_gsprintf
drivers/net/ethernet/amazon/ena/ena_ethtool.c | 25 +-
.../net/ethernet/brocade/bna/bnad_ethtool.c | 266 +++++++-----------
.../ethernet/hisilicon/hns/hns_dsaf_gmac.c | 7 +-
.../net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 37 +--
.../net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 89 ++----
.../ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 6 +-
.../net/ethernet/hisilicon/hns/hns_ethtool.c | 97 +++----
.../net/ethernet/intel/i40e/i40e_ethtool.c | 16 +-
drivers/net/ethernet/intel/ice/ice_ethtool.c | 55 ++--
drivers/net/ethernet/intel/igb/igb_ethtool.c | 40 +--
.../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 40 +--
drivers/net/ethernet/netronome/nfp/abm/main.c | 4 +-
.../ethernet/netronome/nfp/nfp_net_ethtool.c | 79 +++---
drivers/net/ethernet/netronome/nfp/nfp_port.h | 2 -
.../net/ethernet/pensando/ionic/ionic_stats.c | 145 ++++------
drivers/net/hyperv/netvsc_drv.c | 33 +--
drivers/net/virtio_net.c | 18 +-
drivers/net/vmxnet3/vmxnet3_ethtool.c | 53 ++--
18 files changed, 381 insertions(+), 631 deletions(-)
--
next reply other threads:[~2021-03-11 1:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 1:35 Alexander Duyck [this message]
2021-03-11 1:35 ` [RFC PATCH 01/10] ethtool: Add common function for filling out strings Alexander Duyck
2021-03-11 2:08 ` Jakub Kicinski
2021-03-11 20:37 ` Jesse Brandeburg
2021-03-11 1:35 ` [RFC PATCH 02/10] intel: Update drivers to use ethtool_gsprintf Alexander Duyck
2021-03-11 20:32 ` Jesse Brandeburg
2021-03-11 1:35 ` [RFC PATCH 03/10] nfp: Replace nfp_pr_et with ethtool_gsprintf Alexander Duyck
2021-03-11 11:51 ` Simon Horman
2021-03-11 1:35 ` [RFC PATCH 04/10] hisilicon: Update drivers to use ethtool_gsprintf Alexander Duyck
2021-03-11 1:35 ` [RFC PATCH 05/10] ena: Update driver " Alexander Duyck
2021-03-11 13:42 ` Kiyanovski, Arthur
2021-03-11 1:35 ` [RFC PATCH 06/10] netvsc: " Alexander Duyck
2021-03-11 1:35 ` [RFC PATCH 07/10] virtio_net: " Alexander Duyck
2021-03-11 1:36 ` [RFC PATCH 08/10] vmxnet3: " Alexander Duyck
2021-03-11 1:36 ` [RFC PATCH 09/10] bna: " Alexander Duyck
2021-03-11 1:36 ` [RFC PATCH 10/10] ionic: " Alexander Duyck
2021-03-11 17:19 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161542634192.13546.4185974647834631704.stgit@localhost.localdomain \
--to=alexander.duyck@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=akiyano@amazon.com \
--cc=alexanderduyck@fb.com \
--cc=anthony.l.nguyen@intel.com \
--cc=doshir@vmware.com \
--cc=drivers@pensando.io \
--cc=gtzalik@amazon.com \
--cc=haiyangz@microsoft.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jasowang@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=mst@redhat.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pv-drivers@vmware.com \
--cc=rmody@marvell.com \
--cc=saeedb@amazon.com \
--cc=salil.mehta@huawei.com \
--cc=simon.horman@netronome.com \
--cc=skalluru@marvell.com \
--cc=snelson@pensando.io \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox