* [PATCH net-next v2] net: lantiq: Remove redundant dev_err call in xrx200_probe()
@ 2021-03-27 10:31 Huang Guobin
2021-03-29 1:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Huang Guobin @ 2021-03-27 10:31 UTC (permalink / raw)
To: huangguobin4, Hauke Mehrtens, David S. Miller, Jakub Kicinski
Cc: netdev, linux-kernel
From: Guobin Huang <huangguobin4@huawei.com>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
drivers/net/ethernet/lantiq_xrx200.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
index 51ed8a54d380..0f8ef8f1232c 100644
--- a/drivers/net/ethernet/lantiq_xrx200.c
+++ b/drivers/net/ethernet/lantiq_xrx200.c
@@ -460,10 +460,8 @@ static int xrx200_probe(struct platform_device *pdev)
}
priv->pmac_reg = devm_ioremap_resource(dev, res);
- if (IS_ERR(priv->pmac_reg)) {
- dev_err(dev, "failed to request and remap io ranges\n");
+ if (IS_ERR(priv->pmac_reg))
return PTR_ERR(priv->pmac_reg);
- }
priv->chan_rx.dma.irq = platform_get_irq_byname(pdev, "rx");
if (priv->chan_rx.dma.irq < 0)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v2] net: lantiq: Remove redundant dev_err call in xrx200_probe()
2021-03-27 10:31 [PATCH net-next v2] net: lantiq: Remove redundant dev_err call in xrx200_probe() Huang Guobin
@ 2021-03-29 1:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-29 1:10 UTC (permalink / raw)
To: Huang Guobin; +Cc: hauke, davem, kuba, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 27 Mar 2021 18:31:51 +0800 you wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
>
> [...]
Here is the summary with links:
- [net-next,v2] net: lantiq: Remove redundant dev_err call in xrx200_probe()
https://git.kernel.org/netdev/net-next/c/d759c1bd2696
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-29 1:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-27 10:31 [PATCH net-next v2] net: lantiq: Remove redundant dev_err call in xrx200_probe() Huang Guobin
2021-03-29 1:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).