* [PATCH] net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI
@ 2021-04-05 18:15 Krzysztof Kozlowski
2021-04-05 22:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-05 18:15 UTC (permalink / raw)
To: Steve Glendinning, David S. Miller, Jakub Kicinski, netdev,
linux-kernel
Cc: Krzysztof Kozlowski
The driver can match via multiple methods. Its acpi_device_id table is
referenced via ACPI_PTR() so it will be unused for !CONFIG_ACPI builds:
drivers/net/ethernet/smsc/smsc911x.c:2652:36: warning:
‘smsc911x_acpi_match’ defined but not used [-Wunused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 606c79de93a6..556a9790cdcf 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -2649,11 +2649,13 @@ static const struct of_device_id smsc911x_dt_ids[] = {
MODULE_DEVICE_TABLE(of, smsc911x_dt_ids);
#endif
+#ifdef CONFIG_ACPI
static const struct acpi_device_id smsc911x_acpi_match[] = {
{ "ARMH9118", 0 },
{ }
};
MODULE_DEVICE_TABLE(acpi, smsc911x_acpi_match);
+#endif
static struct platform_driver smsc911x_driver = {
.probe = smsc911x_drv_probe,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI
2021-04-05 18:15 [PATCH] net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI Krzysztof Kozlowski
@ 2021-04-05 22:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-05 22:10 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: steve.glendinning, davem, kuba, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 5 Apr 2021 20:15:48 +0200 you wrote:
> The driver can match via multiple methods. Its acpi_device_id table is
> referenced via ACPI_PTR() so it will be unused for !CONFIG_ACPI builds:
>
> drivers/net/ethernet/smsc/smsc911x.c:2652:36: warning:
> ‘smsc911x_acpi_match’ defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> [...]
Here is the summary with links:
- net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI
https://git.kernel.org/netdev/net-next/c/cc0626c2aaed
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-05 22:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-05 18:15 [PATCH] net: smsc911x: skip acpi_device_id table when !CONFIG_ACPI Krzysztof Kozlowski
2021-04-05 22:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).