netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Chan <michael.chan@broadcom.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, kuba@kernel.org, gospo@broadcom.com
Subject: [PATCH net-next 05/10] bnxt_en: allow VF config ops when PF is closed
Date: Sat, 24 Apr 2021 16:14:26 -0400	[thread overview]
Message-ID: <1619295271-30853-6-git-send-email-michael.chan@broadcom.com> (raw)
In-Reply-To: <1619295271-30853-1-git-send-email-michael.chan@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

From: Edwin Peer <edwin.peer@broadcom.com>

It is perfectly legal for the stack to query and configure VFs via PF
NDOs while the NIC is administratively down.  Remove the unnecessary
check for the PF to be in open state.

Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
index 4da52f812585..67856dbf9ce9 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
@@ -49,10 +49,6 @@ static int bnxt_hwrm_fwd_async_event_cmpl(struct bnxt *bp,
 
 static int bnxt_vf_ndo_prep(struct bnxt *bp, int vf_id)
 {
-	if (!test_bit(BNXT_STATE_OPEN, &bp->state)) {
-		netdev_err(bp->dev, "vf ndo called though PF is down\n");
-		return -EINVAL;
-	}
 	if (!bp->pf.active_vfs) {
 		netdev_err(bp->dev, "vf ndo called though sriov is disabled\n");
 		return -EINVAL;
-- 
2.18.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

  parent reply	other threads:[~2021-04-24 20:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-24 20:14 [PATCH net-next 00/10] bnxt_en: Updates for net-next Michael Chan
2021-04-24 20:14 ` [PATCH net-next 01/10] bnxt_en: report signal mode in link up messages Michael Chan
2021-04-24 20:14 ` [PATCH net-next 02/10] bnxt_en: Add a new phy_flags field to the main driver structure Michael Chan
2021-04-24 20:14 ` [PATCH net-next 03/10] bnxt_en: Add support for fw managed link down feature Michael Chan
2021-04-24 20:14 ` [PATCH net-next 04/10] bnxt_en: allow promiscuous mode for trusted VFs Michael Chan
2021-04-24 20:14 ` Michael Chan [this message]
2021-04-24 20:14 ` [PATCH net-next 06/10] bnxt_en: Move bnxt_approve_mac() Michael Chan
2021-04-24 20:14 ` [PATCH net-next 07/10] bnxt_en: Call bnxt_approve_mac() after the PF gives up control of the VF MAC Michael Chan
2021-04-24 20:14 ` [PATCH net-next 08/10] bnxt_en: Add PCI IDs for Hyper-V VF devices Michael Chan
2021-04-24 20:14 ` [PATCH net-next 09/10] bnxt_en: Support IFF_SUPP_NOFCS feature to transmit without ethernet FCS Michael Chan
2021-04-24 20:14 ` [PATCH net-next 10/10] bnxt_en: Implement .ndo_features_check() Michael Chan
2021-04-24 21:52   ` Jakub Kicinski
2021-04-24 23:28     ` Michael Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1619295271-30853-6-git-send-email-michael.chan@broadcom.com \
    --to=michael.chan@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=gospo@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).